Closed Bug 996845 Opened 9 years ago Closed 6 years ago

Test that a tab id does not change when moved from one window to another

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: evold, Unassigned)

References

Details

Someone mentioned that the tab id is changed when moved from one window to another, I would expect that it does not.  We should have a test for this, and a fix if this is not the case imo.
Irakli do you agree with the expected behavior that I mention in comment 0?  also I vaguely recall you opening a platform bug about creating tab ids for xul tabs, like those that exist on fennec, perhaps landing that would be a sufficient fix for this issue (assuming bug 795645 comment 4) is accurate.
Flags: needinfo?(rFobic)
he initial naive implementation just relied on something produced by the platform. It might be worth revisiting this and adding and extra layer:

* for new tabs, create a real uuid at the SDK tab object level
* when tabs travel between windows, preserve this uuid

Note: I still think it is unreasonable to expect tabs to preserve IDs across re-starts.
I (In reply to Erik Vold [:erikvold] [:ztatic] from comment #2)
> Irakli do you agree with the expected behavior that I mention in comment 0? 

I do agree as long as it's implemented by a platform and we don't have to introduce layer of indirection to maintaining id.  

> also I vaguely recall you opening a platform bug about creating tab ids for
> xul tabs, like those that exist on fennec, perhaps landing that would be a
> sufficient fix for this issue (assuming bug 795645 comment 4) is accurate.


I'm afraid landing my patch won't fix the issue, as far as I remember tab.id is generated out of the window id itself and there is no operation of moving across windows. Although I would expect that doing it on platform side should not be pretty straight forward. It could be though that we'll get a pushback from their side.

Relevant discussions and patches can be found under Bug 943671
Flags: needinfo?(rFobic)
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.