996866 - [B2G][Facebook][Contacts] Update Imported Friends button does not sync profile photo

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[mkruml]

Attachment: Logcat of the updating process

Description:
If the user attempts to update their facebook contacts via the 'update imported friends' button, they will find that only the phone number, profile name, and company will update. The profile picture and permissions level of phone number and email will not update unless the user selects the 'sync/desync' slider and reinputs their facebook credentials.

Repro Steps:
1) Update a Tarako to BuildID: 20140415004002
2) Open the Contacts app and tap the gear to go to Settings
3) Select 'sync friends' and input facebook credentials, then import any number of facebook friends to the contacts app
4) In one of the imported facebook accounts, change the profile picture or permissions level of phone/email
5) On the device, go to the Settings again, and tap the 'update imported friends' button, then back out to the contact list after it is finished updating

Actual:
The permissions level of phone number and email (whether or not it is included in the contact info) nor the contact's profile picture will have changed. It requires a complete unsync/resync to update this information.

Expected:
All available information should update appropriately when the 'update imported friends' button is selected.

1.3t Environmental Variables:
Device: Tarako 1.3t MOZ
BuildID: 20140415004002
Gaia: 44ff6248c28ff83b9ad1161847a176399f93d3bb
Gecko: 28aea220e338
Version: 28.1
Firmware Version: sp6821a

Also occurs on Buri 1.3
1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140410004002
Gaia: 62acb4b0e774b6709b8be400d849f807404bb21b
Gecko: 94baf6039462
Version: 28.0
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/5198/ https://moztrap.mozilla.org/manage/case/5199/
See attached logcat: update.txt

Comment 1

[mkruml]

Attachment: Firewatch during the update process

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It looks like there's a first pass and the next sync covers the other part?  I think this is by design.

gtorodelvalle, can you confirm if this is by design please?

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

I am sorry but I cannot confirm it :-( Anyhow, I'll need-info José Manuel since he will probably be able to do it ;-)

Comment 4

[Jose Manuel Cantera]

There is a bug that is preventing from downloading the correct photo when a friend changes his profile picture. I've been investigating a bit and it seems Gecko is incorrectly caching images, thus we are not able to download the new image, we are always getting the old image. 

I don't know who can shed here some light about this new Gecko's behaviour ... Vivien, perhaps? 

Please note that the other reported situations (visibility changes) have been reported many times and that's a Facebook platform issue but not a Gaia / Gecko issue.

Comment 5

[Jose Manuel Cantera]

please can someone from QA check whether this happens as well on 1.3?

Comment 6

[Jose Manuel Cantera]

I can reproduce it on BURI 1.3, thus nominating it for v1.3

Comment 7

[Preeti Raghunath(:Preeti)]

Beatriz,

Would this be a cert blocker? OR can we live with this till the next release?

Comment 8

[Jason Smith [:jsmith]]

(In reply to Jose Manuel Cantera from comment #5)
> please can someone from QA check whether this happens as well on 1.3?

We already checked this - this is reproducible on 1.3.

Comment 9

[Beatriz Rodríguez [:brg]]

(In reply to Preeti Raghunath(:Preeti) from comment #7)
> Beatriz,
> 
> Would this be a cert blocker? OR can we live with this till the next release?
Thanks for asking. Not reported during certification. However this app/feature is very popular and we can face the issue in the close future. Can I suggest to fix it in 1.4?

Comment 10

[Loli (:lolimartinezcr)]

Tested and NOT working today (04/22)
1.5
Hamachi
Gecko 22b3e73
Gaia f046370

Comment 11

[Loli (:lolimartinezcr)]

Tested and NOT working today (04/22)
1.4
Hamachi
Gecko 53aec4a
Gaia 2643291

Comment 12

[Jason Smith [:jsmith]]

Not a cert blocker - so this doesn't block 1.3.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jose Manuel Cantera from comment #4)
> There is a bug that is preventing from downloading the correct photo when a
> friend changes his profile picture. I've been investigating a bit and it
> seems Gecko is incorrectly caching images, thus we are not able to download
> the new image, we are always getting the old image. 
> 
> I don't know who can shed here some light about this new Gecko's behaviour
> ... Vivien, perhaps? 
> 
> Please note that the other reported situations (visibility changes) have
> been reported many times and that's a Facebook platform issue but not a Gaia
> / Gecko issue.

Can you check if any of the approach mentioned at http://mdn.beonex.com/en/DOM/XMLHttpRequest/Using_XMLHttpRequest.html#Bypassing_the_cache works ? (assuming you're doing an XHR to retrieve the image ?)

Comment 14

[Jose Manuel Cantera]

(In reply to Vivien Nicolas (:vingtetun) (:21) (NOT reading bugmails, needinfo? please) from comment #13)
> (In reply to Jose Manuel Cantera from comment #4)
> > There is a bug that is preventing from downloading the correct photo when a
> > friend changes his profile picture. I've been investigating a bit and it
> > seems Gecko is incorrectly caching images, thus we are not able to download
> > the new image, we are always getting the old image. 
> > 
> > I don't know who can shed here some light about this new Gecko's behaviour
> > ... Vivien, perhaps? 
> > 
> > Please note that the other reported situations (visibility changes) have
> > been reported many times and that's a Facebook platform issue but not a Gaia
> > / Gecko issue.
> 
> Can you check if any of the approach mentioned at
> http://mdn.beonex.com/en/DOM/XMLHttpRequest/Using_XMLHttpRequest.
> html#Bypassing_the_cache works ? (assuming you're doing an XHR to retrieve
> the image ?)

Yes, we can do the timestamp trick for XHR, however for images loaded with <img src=""> we are experiencing the same issue ... any additional idea?

thanks!

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jose Manuel Cantera from comment #14)
> (In reply to Vivien Nicolas (:vingtetun) (:21) (NOT reading bugmails,
> needinfo? please) from comment #13)
> > (In reply to Jose Manuel Cantera from comment #4)
> > > There is a bug that is preventing from downloading the correct photo when a
> > > friend changes his profile picture. I've been investigating a bit and it
> > > seems Gecko is incorrectly caching images, thus we are not able to download
> > > the new image, we are always getting the old image. 
> > > 
> > > I don't know who can shed here some light about this new Gecko's behaviour
> > > ... Vivien, perhaps? 
> > > 
> > > Please note that the other reported situations (visibility changes) have
> > > been reported many times and that's a Facebook platform issue but not a Gaia
> > > / Gecko issue.
> > 
> > Can you check if any of the approach mentioned at
> > http://mdn.beonex.com/en/DOM/XMLHttpRequest/Using_XMLHttpRequest.
> > html#Bypassing_the_cache works ? (assuming you're doing an XHR to retrieve
> > the image ?)
> 
> Yes, we can do the timestamp trick for XHR, however for images loaded with
> <img src=""> we are experiencing the same issue ... any additional idea?
> 
> thanks!

Can't you use the timestamp trick for <img src="myimg.png?timestamp"> as well ?

Comment 16

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Added timestamps in the query to download the big pic and avatar's URI on the list as well

Comment 17

[Jose Manuel Cantera]

Comment on attachment 8415151 [details]
Patch v1

please deal with the comments on GH and then merge once Travis is green

Comment 18

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/0895172a698474bfa91d2cc7df85e7184d0ddcf8

Comment 19

[Loli (:lolimartinezcr)]

Tested and working
1.5
Hamachi
Gecko: 6fafefc
Gaia: 0d705e6

Comment 20

[Loli (:lolimartinezcr)]

Change to RESOLVED because it is pending 1.4 and 1.3