Allow flex-grow / flex-shrink to transition between zero and nonzero values

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug, {dev-doc-complete})

Trunk
mozilla32
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Per my www-style post [1]: once we've fixed bug 985304, I believe we should also allow flex items to transition between zero and nonzero values.

(The spec currently prohibits such transitions, but I think the prohibitions are stale, as noted in my www-style post)

[1] http://lists.w3.org/Archives/Public/www-style/2014Apr/0169.html
Tab confirms that we should allow this now:
 http://lists.w3.org/Archives/Public/www-style/2014Apr/0175.html
Posted patch fix v1Splinter Review
Here's the patch to remove this prohibition.

For archeology's sake (and in case it helps with reviewing), this code dates back to the patch that added support for flex-grow & flex-shrink, here:
  http://hg.mozilla.org/mozilla-central/rev/10d1162cd4e1#l6.3
Attachment #8409177 - Flags: review?(matspal)
Comment on attachment 8409177 [details] [diff] [review]
fix v1

r=mats (and thanks for the helpful link)
Attachment #8409177 - Flags: review?(matspal) → review+
Thanks!

[Note: I'm not going to land this until after bug 985304 is fixed, because without that bug fixed, transitions to/from 0 will have a discontinuity in the layout [snapping between very-different renderings] when they go between 0 and 0.000001, which is why we had this prohibition in the first place.]
Status: NEW → ASSIGNED
Landed, after landing bug bug 985304's patches:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3145b567b3
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/6a3145b567b3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.