Closed
Bug 996945
Opened 10 years ago
Closed 10 years ago
Allow flex-grow / flex-shrink to transition between zero and nonzero values
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
7.95 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
Per my www-style post [1]: once we've fixed bug 985304, I believe we should also allow flex items to transition between zero and nonzero values. (The spec currently prohibits such transitions, but I think the prohibitions are stale, as noted in my www-style post) [1] http://lists.w3.org/Archives/Public/www-style/2014Apr/0169.html
Assignee | ||
Comment 1•10 years ago
|
||
Tab confirms that we should allow this now: http://lists.w3.org/Archives/Public/www-style/2014Apr/0175.html
Assignee | ||
Comment 2•10 years ago
|
||
Here's the patch to remove this prohibition. For archeology's sake (and in case it helps with reviewing), this code dates back to the patch that added support for flex-grow & flex-shrink, here: http://hg.mozilla.org/mozilla-central/rev/10d1162cd4e1#l6.3
Attachment #8409177 -
Flags: review?(matspal)
Assignee | ||
Comment 3•10 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=c023fa041263
Comment 4•10 years ago
|
||
Comment on attachment 8409177 [details] [diff] [review] fix v1 r=mats (and thanks for the helpful link)
Attachment #8409177 -
Flags: review?(matspal) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks! [Note: I'm not going to land this until after bug 985304 is fixed, because without that bug fixed, transitions to/from 0 will have a discontinuity in the layout [snapping between very-different renderings] when they go between 0 and 0.000001, which is why we had this prohibition in the first place.]
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•10 years ago
|
||
Landed, after landing bug bug 985304's patches: https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3145b567b3
Flags: in-testsuite+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6a3145b567b3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Updated•9 years ago
|
Blocks: flexbox-spec-changes
Updated•9 years ago
|
Keywords: dev-doc-needed
Comment 8•9 years ago
|
||
Updated: https://developer.mozilla.org/en-US/Firefox/Releases/32 https://developer.mozilla.org/en-US/docs/Web/CSS/flex-grow https://developer.mozilla.org/en-US/docs/Web/CSS/flex-shrink
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•