996945 - Allow flex-grow / flex-shrink to transition between zero and nonzero values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

Per my www-style post [1]: once we've fixed bug 985304, I believe we should also allow flex items to transition between zero and nonzero values.

(The spec currently prohibits such transitions, but I think the prohibitions are stale, as noted in my www-style post)

[1] http://lists.w3.org/Archives/Public/www-style/2014Apr/0169.html

Comment 1

[Daniel Holbert [:dholbert]]

Tab confirms that we should allow this now:
 http://lists.w3.org/Archives/Public/www-style/2014Apr/0175.html

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Here's the patch to remove this prohibition.

For archeology's sake (and in case it helps with reviewing), this code dates back to the patch that added support for flex-grow & flex-shrink, here:
  http://hg.mozilla.org/mozilla-central/rev/10d1162cd4e1#l6.3

Comment 3

[Daniel Holbert [:dholbert]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=c023fa041263

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 8409177 [details] [diff] [review]
fix v1

r=mats (and thanks for the helpful link)

Comment 5

[Daniel Holbert [:dholbert]]

Thanks!

[Note: I'm not going to land this until after bug 985304 is fixed, because without that bug fixed, transitions to/from 0 will have a discontinuity in the layout [snapping between very-different renderings] when they go between 0 and 0.000001, which is why we had this prohibition in the first place.]

Comment 6

[Daniel Holbert [:dholbert]]

Landed, after landing bug bug 985304's patches:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3145b567b3

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6a3145b567b3

Comment 8

[Jean-Yves Perrier [:teoli]]

Updated:
https://developer.mozilla.org/en-US/Firefox/Releases/32
https://developer.mozilla.org/en-US/docs/Web/CSS/flex-grow
https://developer.mozilla.org/en-US/docs/Web/CSS/flex-shrink