996968 - Intermittent gaia-integration TEST-UNEXPECTED-FAIL | Update bookmark on homescreen > Navigate to sample.html and bookmark it on homescreen "before each" hook

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: test screenshot

https://tbpl.mozilla.org/php/getParsedLog.php?id=37855229&tree=B2g-Inbound

b2g_ubuntu64_vm b2g-inbound opt test gaia-integration on 2014-04-15 09:31:38 PDT for push d78b03b93ba7
slave: tst-linux64-spot-969

09:58:40     INFO -  TEST-START | Update bookmark on homescreen  > Navigate to sample.html and bookmark it on homescreen  sample.html has a new title
09:59:12     INFO -  Screenshot: 
09:59:12     INFO -  TEST-UNEXPECTED-FAIL | Update bookmark on homescreen  > Navigate to sample.html and bookmark it on homescreen "before each" hook

Comment 1

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=37898059&tree=Mozilla-Central
b2g_ubuntu64_vm mozilla-central opt test gaia-integration on 2014-04-15 21:14:01
revision: 16e9cda44250
slave: tst-linux64-spot-245

TEST-UNEXPECTED-FAIL | Update bookmark on homescreen "before each" hook
make: *** [test-integration-test] Error 1
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 2

[Kevin Grandon :kgrandon]

All of the bookmark tests have now been disabled on tbpl and travis until this can be fixed.

https://github.com/mozilla-b2g/gaia/commit/a70989f361d6426ab2a9d413ac987c418aee9a8e

FWIW - all bookmark tests seem to be failing on the same bookmark_editor line.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Turns out this one wasn't too difficult. Verified this works on travis: https://travis-ci.org/mozilla-b2g/gaia/builds/23313254

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8409173 [details] [review]
Github pull request

Hey Guys - anyone available for a quick review of this patch? Thanks!

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8409173 [details] [review]
Github pull request

Looks good to me. Thanks for the patch.

By the way, have you try it on try server? I think it'd be better to push to try server before landing.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8409173 [details] [review]
Github pull request

Thanks! These were previously being run on TBPL though intermittent. I have a fairly good amount of confidence in it, so I'll push and if it doesn't work we can investigate further.

Comment 7

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/eb97461e75cd44d20967bc410b5653dff031ef5a

Marking as fixed, but Ryan please re-open if you see this on tbpl again.