996989 - Import PopupNotifications.jsm lazily into PeerConnection.js

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Nicholas Nethercote [inactive]]

PopupNotification.jsm can be imported lazily, AFAICT.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Import PopupNotifications.jsm lazily into PeerConnection.js

The identifier |PopupNotifications| doesn't actually appear anywhere in
PeerConnection.js, so it might instead be possible to just remove the import.

Comment 2

[Nicholas Nethercote [inactive]]

BTW, I confirmed that this prevents the creation of a PopupNotifications.jsm compartment at start-up.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Nicholas Nethercote [:njn] from comment #1)
> The identifier |PopupNotifications| doesn't actually appear anywhere in
> PeerConnection.js, so it might instead be possible to just remove the import.

Martin, this looks left over from the UI that got pulled in Bug 884573 comment 88 - OK to remove?

Comment 4

[Martin Thomson [:mt:]]

(In reply to Jan-Ivar Bruaroey [:jib] from comment #3)
> (In reply to Nicholas Nethercote [:njn] from comment #1)
> > The identifier |PopupNotifications| doesn't actually appear anywhere in
> > PeerConnection.js, so it might instead be possible to just remove the import.
> 
> Martin, this looks left over from the UI that got pulled in Bug 884573
> comment 88 - OK to remove?

Absolutely!  Nuke it.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8407281 [details] [diff] [review]
Import PopupNotifications.jsm lazily into PeerConnection.js

Nicholas do you want to do the honors?

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: Remove unneeded import of PopupNotifications.jsm in PeerConnection.js

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70bb7587900c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70bb7587900c