Closed Bug 996989 Opened 7 years ago Closed 7 years ago

Import PopupNotifications.jsm lazily into PeerConnection.js

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

PopupNotification.jsm can be imported lazily, AFAICT.
The identifier |PopupNotifications| doesn't actually appear anywhere in
PeerConnection.js, so it might instead be possible to just remove the import.
Attachment #8407281 - Flags: review?(jib)
BTW, I confirmed that this prevents the creation of a PopupNotifications.jsm compartment at start-up.
(In reply to Nicholas Nethercote [:njn] from comment #1)
> The identifier |PopupNotifications| doesn't actually appear anywhere in
> PeerConnection.js, so it might instead be possible to just remove the import.

Martin, this looks left over from the UI that got pulled in Bug 884573 comment 88 - OK to remove?
Flags: needinfo?(martin.thomson)
(In reply to Jan-Ivar Bruaroey [:jib] from comment #3)
> (In reply to Nicholas Nethercote [:njn] from comment #1)
> > The identifier |PopupNotifications| doesn't actually appear anywhere in
> > PeerConnection.js, so it might instead be possible to just remove the import.
> 
> Martin, this looks left over from the UI that got pulled in Bug 884573
> comment 88 - OK to remove?

Absolutely!  Nuke it.
Flags: needinfo?(martin.thomson)
Comment on attachment 8407281 [details] [diff] [review]
Import PopupNotifications.jsm lazily into PeerConnection.js

Nicholas do you want to do the honors?
Attachment #8407281 - Flags: review?(jib)
Attachment #8407281 - Attachment is obsolete: true
Attachment #8407405 - Flags: review?(jib) → review+
https://hg.mozilla.org/mozilla-central/rev/70bb7587900c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.