Closed
Bug 996989
Opened 10 years ago
Closed 10 years ago
Import PopupNotifications.jsm lazily into PeerConnection.js
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file, 1 obsolete file)
1.23 KB,
patch
|
jib
:
review+
|
Details | Diff | Splinter Review |
PopupNotification.jsm can be imported lazily, AFAICT.
Assignee | ||
Comment 1•10 years ago
|
||
The identifier |PopupNotifications| doesn't actually appear anywhere in PeerConnection.js, so it might instead be possible to just remove the import.
Attachment #8407281 -
Flags: review?(jib)
Assignee | ||
Comment 2•10 years ago
|
||
BTW, I confirmed that this prevents the creation of a PopupNotifications.jsm compartment at start-up.
Comment 3•10 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #1) > The identifier |PopupNotifications| doesn't actually appear anywhere in > PeerConnection.js, so it might instead be possible to just remove the import. Martin, this looks left over from the UI that got pulled in Bug 884573 comment 88 - OK to remove?
Flags: needinfo?(martin.thomson)
Comment 4•10 years ago
|
||
(In reply to Jan-Ivar Bruaroey [:jib] from comment #3) > (In reply to Nicholas Nethercote [:njn] from comment #1) > > The identifier |PopupNotifications| doesn't actually appear anywhere in > > PeerConnection.js, so it might instead be possible to just remove the import. > > Martin, this looks left over from the UI that got pulled in Bug 884573 > comment 88 - OK to remove? Absolutely! Nuke it.
Flags: needinfo?(martin.thomson)
Comment 5•10 years ago
|
||
Comment on attachment 8407281 [details] [diff] [review] Import PopupNotifications.jsm lazily into PeerConnection.js Nicholas do you want to do the honors?
Attachment #8407281 -
Flags: review?(jib)
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8407405 -
Flags: review?(jib)
Assignee | ||
Updated•10 years ago
|
Attachment #8407281 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8407405 -
Flags: review?(jib) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/70bb7587900c
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/70bb7587900c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•