Closed
Bug 997006
Opened 10 years ago
Closed 10 years ago
rename text-combine-horizontal to text-combine-upright
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: jtd, Assigned: jtd)
References
Details
Attachments
(1 file)
20.67 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Just before CR, the text-combine-horizontal property was renamed to text-combine-upright. Need to update parsing code to updated property name.
Assignee | ||
Comment 1•10 years ago
|
||
http://www.w3.org/TR/css-writing-modes-3/#text-combine-upright
Assignee | ||
Comment 2•10 years ago
|
||
Pretty much a straight search-and-replace. Within constants, _UPRIGHT is substituted for _HORIZ.
Attachment #8407305 -
Flags: review?(dholbert)
Comment 3•10 years ago
|
||
Comment on attachment 8407305 [details] [diff] [review] patch, rename text-combine-horizontal property to text-combine-upright >Bug 997006 - update text-combine-horizontal to text-combine-upright. r?dholbert maybe s/update/rename/ in the commit message? r=me regardless
Attachment #8407305 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Pushed to inbound, commit message revised. https://hg.mozilla.org/integration/mozilla-inbound/rev/faeaf2881148
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/faeaf2881148
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•