997152 - Intermittent oscillator-ended-1.html | Exited with code -1073741819 during test run | application crashed [@ mozilla::AudioNodeExternalInputStream::TrackMapEntry::ResampleChannels(nsTArray<void const *> const &,unsigned int,mozilla::AudioSampleFormat,flo

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Carsten Book [:Tomcat]]

Windows 7 32-bit mozilla-inbound opt test crashtest on 2014-04-16 04:20:12 PDT for push fea151789006

slave: t-w732-ix-058

https://tbpl.mozilla.org/php/getParsedLog.php?id=37918885&tree=Mozilla-Inbound

TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code -1073741819 during test run

PROCESS-CRASH | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::AudioNodeExternalInputStream::TrackMapEntry::ResampleChannels(nsTArray<void const *> const &,unsigned int,mozilla::AudioSampleFormat,float)]

Comment 1

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=37987560&tree=Mozilla-Inbound
Windows 7 32-bit mozilla-inbound pgo test crashtest on 2014-04-16 23:54:25
revision: f1cbde906d5d
slave: t-w732-ix-057

TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code -1073741819 during test run
PROCESS-CRASH | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::AudioNodeExternalInputStream::TrackMapEntry::ResampleChannels(nsTArray<void const *> const &,unsigned int,mozilla::AudioSampleFormat,float)]
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=38143204&tree=Mozilla-Central
Rev5 MacOSX Mountain Lion 10.8 mozilla-central debug test crashtest on 2014-04-19 05:48:58
revision: fd7c870fa960
slave: talos-mtnlion-r5-010

TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code 1 during test run
PROCESS-CRASH | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::MediaStream::RemoveAllListenersImpl()]
Return code: 1

Comment 3

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/annotate/fea151789006/content/media/AudioNodeExternalInputStream.cpp#l171
https://hg.mozilla.org/integration/mozilla-inbound/annotate/fea151789006/content/media/AudioNodeExternalInputStream.cpp#l198

Suspecting a non-null chunk with zero channels.

Comment 5

[Karl Tomlinson (:karlt)]

Guessing this is happening since changes in bug 991504

Comment 6

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=38305134&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound pgo test crashtest on 2014-04-22 23:58:24
revision: 891de7042cd4
slave: t-w864-ix-022

TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code -1073741819 during test run
PROCESS-CRASH | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::AudioNodeExternalInputStream::TrackMapEntry::ResampleChannels(nsTArray<void const *> const &,unsigned int,mozilla::AudioSampleFormat,float)]
Return code: 1

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: improve the estimate of null chunk duration and produce null chunks in AudioSegment::Resample()

There can still be accumulated errors from rounding.  I don't know how much that matters.  At least skipping samples during silence will not be audible.

Comment 8

[Karl Tomlinson (:karlt)]

OK on try, except for bug 969392, which seems to be almost perma-fail already
https://tbpl.mozilla.org/?tree=Try&rev=ca203660bbca
https://tbpl.mozilla.org/?tree=Try&rev=bdf822c55148

Comment 9

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=38594302&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test crashtest on 2014-04-27 15:36:56
revision: b50bcf913c9b
slave: t-w864-ix-024

TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code -1073741819 during test run
PROCESS-CRASH | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::AudioNodeExternalInputStream::TrackMapEntry::ResampleChannels(nsTArray<void const *> const &,unsigned int,mozilla::AudioSampleFormat,float)]
Return code: 1

Comment 10

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=38596465&tree=Fx-Team
WINNT 6.2 fx-team opt test crashtest on 2014-04-27 17:24:33
revision: cebe712acbab
slave: t-w864-ix-033

TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code -1073741819 during test run
PROCESS-CRASH | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::AudioNodeExternalInputStream::TrackMapEntry::ResampleChannels(nsTArray<void const *> const &,unsigned int,mozilla::AudioSampleFormat,float)]
Return code: 1

Comment 11

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=38607433&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test crashtest on 2014-04-27 21:37:57
revision: d9a6a378349a
slave: t-w864-ix-056

TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code -1073741819 during test run
PROCESS-CRASH | file:///C:/slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::AudioNodeExternalInputStream::TrackMapEntry::ResampleChannels(nsTArray<void const *> const &,unsigned int,mozilla::AudioSampleFormat,float)]
Return code: 1

Comment 12

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=38811638&tree=Mozilla-Aurora
Rev5 MacOSX Mountain Lion 10.8 mozilla-aurora debug test crashtest on 2014-04-30 09:23:48
revision: ae2af33e459f
slave: talos-mtnlion-r5-001

TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | Exited with code 1 during test run
PROCESS-CRASH | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/content/media/test/crashtests/oscillator-ended-1.html | application crashed [@ mozilla::dom::AudioBufferSourceNode::DestroyMediaStream()]
Return code: 1

Comment 13

[Karl Tomlinson (:karlt)]

Landed in mozilla-central changeset 8a69388a1a21.