Closed
Bug 997178
Opened 11 years ago
Closed 11 years ago
Loop client should allow end user to restart a terminated conversation
Categories
(Hello (Loop) :: Client, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla33
People
(Reporter: NiKo, Unassigned)
References
Details
User Story
As a user, when an ongoing call ends and I'm redirected to the call start UI, I should be able to restart the call using the same session settings.
Attachments
(1 file)
Follow up to bug 972019.
Assignee | ||
Updated•11 years ago
|
User Story: (updated)
Assignee | ||
Updated•11 years ago
|
User Story: (updated)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → nperriault
Assignee | ||
Comment 1•11 years ago
|
||
This patch fixes a limitation where a call couldn't be restarted because the server wasn't notified anymore from the call attempt.
Also, fixed a leak with the ConversationModel keeping listening to every created partner session object, which caused duplicated notifications being displayed to the end user.
Attachment #8415331 -
Flags: review?(dmose)
Comment 2•11 years ago
|
||
Comment on attachment 8415331 [details] [review]
https://github.com/mozilla/loop-client/pull/26
r=dmose
Attachment #8415331 -
Flags: review?(dmose) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Landed onto loop-client master: https://github.com/mozilla/loop-client/commit/1213df08ad8d8029c3cff35d8619a4cc70e963ab
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla33
Looks like this landed with tests. Does this need QA testing?
QA Contact: anthony.s.hughes
Whiteboard: [qa?]
Marking this verified fixed based on recent smoketesting.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Whiteboard: [qa?]
You need to log in
before you can comment on or make changes to this bug.
Description
•