997297 - Wrong package name used to launch application when supplying branch

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[William Lachance (:wlach)]

From AaronMT on github:

E.g,

--repo=mozilla-aurora--android

Starting nightly:
Starting: Intent { cmp.org.mozilla.fennec/.App }
Error type 3
Error: Activity class {org.mozilla.fennec/org.mozilla.fennec.App } does not exist

It should look for org.mozilla.fennec_aurora in this case.

Comment 1

[William Lachance (:wlach)]

I think we can actually fix this by peeking inside the .apk and getting the application name from there. Probably easier than doing a bunch of hardcoded logic. This might be a fun bug for someone with an Android phone to tackle.

Comment 2

[Aaron Train [:aaronmt]]

If we have access to appt, you can dump out 'application-label', e.g, 

 application-label:'Firefox Beta'

Comment 3

[Julien Pagès (:parkouss)]

Ok, I found where the info is in the apk I think - in the package-name.txt file.

Well, it will be easy to get the information here. However I wonder if that could be useful to get this information directly from mozversion ? We could add a key 'package-name' with the corresponding value in the dict returned by mozversion;

Will, what do you think ?

Comment 4

[William Lachance (:wlach)]

(In reply to Julien Pagès from comment #3)
> Ok, I found where the info is in the apk I think - in the package-name.txt
> file.
> 
> Well, it will be easy to get the information here. However I wonder if that
> could be useful to get this information directly from mozversion ? We could
> add a key 'package-name' with the corresponding value in the dict returned
> by mozversion;
> 
> Will, what do you think ?

Good question. It seems to make sense to me. Maybe :davehunt has other opinions though?

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

mozversion seems like a good place for this.

Comment 6

[Julien Pagès (:parkouss)]

Attachment: Wrong package name used to launch application when supplying branch

this uses the new release of mozversion 1.2.

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8564278 [details] [review]
Wrong package name used to launch application when supplying branch

Awesome, ty!

Comment 8

[Julien Pagès (:parkouss)]

Great, this is merged in! Next release of mozregression will use the right package name.