997364 - test_BoundedFileAppender logs 'A promise chain failed to handle a rejection'

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[:Irving Reid (No longer working on Firefox)]

0:05.43 TEST-KNOWN-FAIL | None | Once bug 976205 has landed, THIS ERROR WILL CAUSE A TEST FAILURE.
 A promise chain failed to handle a rejection: Unix error 9 during operation accessing file (Bad file descriptor) - rejection date: Wed Apr 16 2014 15:33:12 GMT-0400 (EDT)


In toolkit/modules/tests/xpcshell/test_Log.js, the BoundedFileAppender tests log an error from an unhandled Promise rejection; some WIP Promise test harness I'm trying out points at this line in FileAppender.doAppend()

>>     this._lastWritePromise = this._getFile().then(_ => {

called from BoundedFileAppender.doAppend()

>>     return FileAppender.prototype.doAppend.call(this, formatted);

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Make fileAppender chain promises on file creation.;

try:

https://tbpl.mozilla.org/?tree=Try&rev=f4eafb6272da

Comment 3

[David Teller [:Yoric] - still alive but not very active]

This is one of the last blockers for bug 976205. Any hope to land this soon?

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Make fileAppender chain promises on file creation.

Unbitrot. This should be good to go.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/6a53e2f1396d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a53e2f1396d