997504 - Reader mode removes links from a page with no paragraphs

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect, P4)

Description

[Kevin Brosnan [Ex-Mozilla]]

Attachment: 997479.html

If a document fails to use any paragraph or div tags then the anchor pages for the page are removed.

Comment 1

[:Margaret Leibovic]

With bug 786638, it should be pretty easy to add this testcase to our test suite once this is fixed. We would just need to augment it to check the expected content more closely.

Comment 2

[:Gijs (he/him)]

I think this is WFM with current fx-team. Margaret, can you doublecheck if I understood this correctly? Do you think we should add a testcase anyway?

Comment 3

[:Margaret Leibovic]

(In reply to :Gijs Kruitbosch from comment #2)
> I think this is WFM with current fx-team. Margaret, can you doublecheck if I
> understood this correctly? Do you think we should add a testcase anyway?

Yes, I also see this works. I'm not sure what problem kbrosnan was seeing, but it's probably something that was fixed by our logic error fixes, not by any algorithm tweaks, so I bet this is unlikely to regress.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Every instance of <a href=...>words</a> were striped from the document. This is currently resolved in v39s. Fairly trivial to check against Firefox 38.