997521 - Prepopulate default history and top sites

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[Dale Harvey (:daleharvey)]

Assets defined in https://bugzilla.mozilla.org/show_bug.cgi?id=992884

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/18431

The type check was removed from the favicon function because our xhr resolved app files to 'application/xml', which is fun, I suspect its a default when no type was provided, but the subsequent checks are solid so its fine to be removed

I suspect eric / visuals will want to rethink how we display favicons, the idea of sampling from the edge is not going to work, favicons are generally designed to work against light backgrounds, but not part of this bug.

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 8408441 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18431

This is fine as a temporary measure.

Comment 4

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/4d0597fcd9f283c4e4d54be63c067f77c5f1d849

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Reverted for Gaia unit test failures.
https://github.com/mozilla-b2g/gaia/commit/5068997641edd75aafeb969a7d0e084d9b90f2b5

https://tbpl.mozilla.org/php/getParsedLog.php?id=38054230&tree=B2g-Inbound

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/18453

Given the unit tests failures, I decided to to this in a cleaner way, its just a start and we will need to turn places into a properly instantiate api, but this starts it

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8408980 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18453

Hey - I am assuming that you're missing places_preload.js as not adding files is a common thing that I do with git as well :)

Please add and re-flag me for review.

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 8408980 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18453

Ugh second commit I forgot to add files, apologies, added

Comment 9

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/84f4835833c4cb8ac7e5d9e0c94738b1cb0ef45a