Closed
Bug 997521
Opened 11 years ago
Closed 11 years ago
Prepopulate default history and top sites
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S6 (25apr)
People
(Reporter: daleharvey, Assigned: daleharvey)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file, 1 obsolete file)
No description provided.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dale
|
|
Assignee | |
Comment 1•11 years ago
|
||
Assets defined in https://bugzilla.mozilla.org/show_bug.cgi?id=992884
|
||
Updated•11 years ago
|
Summary: Prepoulate default history and top sites → Prepopulate default history and top sites
|
|
Assignee | |
Comment 2•11 years ago
|
||
The type check was removed from the favicon function because our xhr resolved app files to 'application/xml', which is fun, I suspect its a default when no type was provided, but the subsequent checks are solid so its fine to be removed
I suspect eric / visuals will want to rethink how we display favicons, the idea of sampling from the edge is not going to work, favicons are generally designed to work against light backgrounds, but not part of this bug.
Attachment #8408441 -
Flags: review?(bfrancis)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8408441 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18431
This is fine as a temporary measure.
Attachment #8408441 -
Flags: review?(bfrancis) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 5•11 years ago
|
||
Reverted for Gaia unit test failures.
https://github.com/mozilla-b2g/gaia/commit/5068997641edd75aafeb969a7d0e084d9b90f2b5
https://tbpl.mozilla.org/php/getParsedLog.php?id=38054230&tree=B2g-Inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•11 years ago
|
||
Given the unit tests failures, I decided to to this in a cleaner way, its just a start and we will need to turn places into a properly instantiate api, but this starts it
Attachment #8408441 -
Attachment is obsolete: true
Attachment #8408980 -
Flags: review?(kgrandon)
|
||
Comment 7•11 years ago
|
||
Comment on attachment 8408980 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18453
Hey - I am assuming that you're missing places_preload.js as not adding files is a common thing that I do with git as well :)
Please add and re-flag me for review.
Attachment #8408980 -
Flags: review?(kgrandon)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 8408980 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18453
Ugh second commit I forgot to add files, apologies, added
Attachment #8408980 -
Flags: review?(kgrandon)
|
|
||
Updated•11 years ago
|
Attachment #8408980 -
Flags: review?(kgrandon) → review+
|
|
||
Comment 9•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 1.4 S6 (25apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•