997606 - [NFC] Arrow truncate on shrinking UI

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Alison Shiue]

Attachment: S__352276.jpg

2014/4/16 build from pvt

STR:
1. Enable NFC on both phones
2. Open browser on phone A
3. Tap two phones
4. Check shrinking UI

Expected result:
Array truncate

Actual result:
No truncate

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Alison, 
can you also attach a normal picture?

Comment 2

[Alison Shiue]

Attachment: NFC_Landscape.png

Please refer this attached image, array on shrinking UI should look likes it.

Comment 3

[Bruce Huang [:bhuang] (inactive)]

Low impact, backlog.

Comment 4

[Ken Chang[:kenkai]]

according comment 3, remove it from blockers of 2.0.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I think this is already fixed.

Comment 6

[Alison Shiue]

Attachment: 2014-08-20-09-57-48.png

No, this issue still exist.

Comment 7

[Alison Shiue]

The screenshot from:
Gaia      de7235e41f36a23a31c5e47218473c0cc471b019
Gecko     https://hg.mozilla.org/mozilla-central/rev/149d3ce6e020
BuildID   20140819160208
Version   34.0a1

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

[Blocking Requested - why for this release]:
If the arrow cannot be shown correctly, first time user can't know how to swipe.
Also this bug exists for a while, that means the Shrinking-UI has problems on fitting multi-resolution device, other B2G devices, such as Nexus, and 2.0 devices used by parters could also have this.

And this Shrinking UI is system-wise, which means all Apps using ShrinkingUI (Contacts, Browser, Galley, Music, Video) will have this problem.

Nominate this to 2.0

Comment 9

[Dietrich Ayala (:dietrich)]

This does not block usage of the feature and there are many other UI indications of the swipe. It's also very late to land polish-level changes like this for 2.0. Moving to backlog.

Yoshi, if you think it blocks, please confer with the product owner for NFC and renominate. Thanks!

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ni? for UX, is 'half arrow' shown in Comment 6 acceptable for UX?

Comment 11

[Juwei Huang[:juwei]]

It is NOT acceptable in UX perspective. I screen shot some of the screens in my device:
https://www.dropbox.com/s/etojrlc1whuik45/NFC_Arrow_truncate_l_2.png
https://www.dropbox.com/s/tat2nbg3h9mz6po/NFC_Arrow_truncate_l.png
https://www.dropbox.com/s/pd8v2mefqwn0krb/NFC_Arrow_truncate_p.png

I see sometimes the arraw is cut in half, sometime it's gone. In landscape mode, it sometimes even no script at all.

I know it might be late now, however, as Yoshi said, without the correct UI display, user doesn't not know how to do on the shrinking screen. I think it's important to provide a solid UI to guide user to the correct behaviour.

So I highly recommend that we fix this bug as soon as possible. If there's anything I can help in UI side, I am happy to provide visual assets anytime.

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ni? for Weskley for Comment 11 to nominate this to 2.0+

Comment 13

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

IMO, it's an obvious flaw, especially on Flame.
As the timing is a bit late for 2.0 fixes, I'm leaving this call to product.
ni? Sandip.

Comment 14

[Sandip Kamat]

There are 2 kinds of use cases apart from the arrow issue. 

1. Cases Where user can still see the text "swipe to share"
2. cases Where users can't see "swipe to share" at all (see one of Juwei's examples above).

In case of #1, UI impact is low as users can at least read the text. 
In case of #2, the user impact is high. Users don't know what to do, They don't see arrow or text. Note that 2.0 is our first (ever) NFC support release and this handicap does not look polished. 

If there are risks to fix it fully, can a solution be found to avoid case #2?

BTW why is this coming at this time? This issue has been open since April.

Comment 15

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Ni? for Greg and Alive for Sandip's question in Comment 14.

Meanwhile request to nominate this 2.1+.
But if it's reasonable to make it 2.0+ please nominate to 2.0+

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Clearing needinfo because I am not actively working on shrinking UI bugs. Will bypass to George if Greg is full occupied.

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

While I'm occupied fully with LockScreen 2.1 features, I temporarily have no time to investigate this bug...I'll dive into it when it's possible.

Also, I remembered I fixed this one on Nexus 4. So it's may be a device (resolution) related issue, this means it's necessary to investigate to see if we can find a solution to fix it on as much as possible devices.

I'll NI myself to keep it in queue.

Comment 18

[Sandip Kamat]

Thanks Greg. Will be great to get this in so our first launch of NFC with 2.0 release is well received from UX perspective.

Comment 19

[(Inactive after June) George Duan [:gduan] [:喬智]]

take it

Comment 20

[Dietrich Ayala (:dietrich)]

(In reply to Juwei Huang from comment #11)
> It is NOT acceptable in UX perspective. I screen shot some of the screens in
> my device:
> https://www.dropbox.com/s/etojrlc1whuik45/NFC_Arrow_truncate_l_2.png
> https://www.dropbox.com/s/tat2nbg3h9mz6po/NFC_Arrow_truncate_l.png
> https://www.dropbox.com/s/pd8v2mefqwn0krb/NFC_Arrow_truncate_p.png

Wow, these are far worse than the original attachments.

Juwei, does UX team have a set of screen sizes and resolutions that engineers should use to test their code? It might help developers and code-reviewers when evaluating if a big UI feature like this one is ready to land.

Comment 21

[Juwei Huang[:juwei]]

Hi Dietrich, it looks bad indeed.
I believe visual team has different resolutions for dev.
Need info Fang.

Hi Fang,
Can you help to see the link attached on comment 11?
Is there anything we can help such as provide different resolution assets for developers?

Comment 22

[Fang Shih [:fang]]

Attachment: NFC_VisualSpec.zip

Attached the updated assets & visual spec, Thanks!

Comment 23

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

patch is ready. waiting for ui review.

Comment 24

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: after_patch.zip

Hi Fang,
could you do a ui review for it?
the zip file contains portrait and landscape cases when tilting. I'll prepare one device for you to check tmr.

Comment 25

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: after_patch_screenshots.zip

Hi Fang,
please kindly review the ui part. Thanks.

Comment 26

[Fang Shih [:fang]]

Comment on attachment 8482470 [details]
after_patch_screenshots.zip

Looks great, thanks for all your help George!

Comment 27

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8482470 [details]
after_patch_screenshots.zip

Hi Alive,
could you review this patch?
I updated as below,
1. shrinkingUI should also treat landscape-secondary as landscape, so does portrait.
2. the ui refresh
3. for new app-chrome design, we need to do some css modification to make sure fullscreenapp/normalapp/appbrowser with same shrinking ui effect.

Comment 28

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8482324 [details] [review]
PR to master

Please read https://github.com/mozilla-b2g/gaia/pull/23585/files#r16980469 and tell me if that works for you.

Comment 29

[(Inactive after June) George Duan [:gduan] [:喬智]]

reply to comment 28,
it works! Thanks for advise.

master: https://github.com/mozilla-b2g/gaia/commit/c0da4a4982113b0dbe3beaa15a215dd8a320ce80

Comment 30

[(Inactive after June) George Duan [:gduan] [:喬智]]

It also affect 2.0 and 2.1 branch.

Comment 31

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 997606
[User impact] if declined:  as attachment 8408030 [details]
[Testing completed]: unit test has covered part of this change. Mostly are ui change.
[Risk to taking this patch] (and alternatives if risky): Mostly are ui change, so I don't think it's risky.
[String changes made]: None.

Comment 32

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 997606
[User impact] if declined:  as attachment 8408030 [details]
[Testing completed]: unit test has covered part of this change. Mostly are ui change.
[Risk to taking this patch] (and alternatives if risky): Mostly are ui change, so I don't think it's risky.
[String changes made]: None.

Comment 33

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/bbf4b9caf89249a20a681a2d8876544b2cb62863

Comment 34

[bhavana bajaj [:bajaj]]

Sandip, its too late on anything no-blocking to land on 2.0 at this point. I understand the desire from product on having a crisped up UI for a new feature for 2.0, but this way is too late. If this was unacceptable, it should have been blocked on by product early-on. Multiple people on this bug have agreed that this isn't a ship-blocker. This is going to get fixed/cleaned-up in 2.1.

Comment 35

[Sandip Kamat]

Bhavana, The 2.0+ blocking flag was not added due to the timing of this and unknown risks involved at that time. I would like this to be made available for latest Flame (which it will get), but specifically for our OEM partners to cherry pick. From Product perspective, this fix is essential for 2.0 commercial NFC launches. What mechanism do we have to indicate this to partners? (release notes is one way I think)

Comment 36

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1 and 2.2.

Result: The arrow under "Swipe to share" is displayed properly.

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141105001204
Gaia: 154da5e17029a51002d5d9b7df39563d509edde6
Gecko: 3b0c3580a58d
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141105040206
Gaia: 7c9e7cabbde941b976e0e40a3a1d94e21aa9c5e9
Gecko: 62990ec7ad78
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0