Closed Bug 997622 Opened 10 years ago Closed 10 years ago

[markup view] Expand all descendants on Alt+Click

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: pbro, Assigned: pbro)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

I just realized Chrome DevTools have this awesome sort-of-hidden feature where if you alt+click a node in the markup panel, not only the node with expand, but all of its descendants too.

It's super easy to do in the Firefox Devtools too, because we already have the function that does it: MarkupView.expandAll(node). By the way that function doesn't seem to be used anywhere.
Works, no tests yet though.
Assignee: nobody → pbrosset
This time with tests, and a try build: https://tbpl.mozilla.org/?tree=Try&rev=6b1aae0ba9cb
Attachment #8408054 - Attachment is obsolete: true
Attachment #8408091 - Flags: review?(jwalker)
Attachment #8408091 - Flags: review?(jwalker) → review+
Comment on attachment 8408091 [details] [diff] [review]
bug997622-expand-all-markupview v2.patch

Review of attachment 8408091 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/markupview/markup-view.js
@@ +1418,5 @@
>  
>    _onToggle: function(event) {
>      this.markup.navigate(this);
>      if(this.hasChildren) {
> +      this.markup.setNodeExpanded(this.node, !this.expanded, event.altKey);

Note: on windows/linux I believe it is CTRL + ALT + Click.
(In reply to Brian Grinstead [:bgrins] from comment #3)
> Note: on windows/linux I believe it is CTRL + ALT + Click.
That's correct, although I don't understand why. It feels simpler to have alt+click on all platforms, and I don't think alt+click is already bound to any other action.
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #4)
> (In reply to Brian Grinstead [:bgrins] from comment #3)
> > Note: on windows/linux I believe it is CTRL + ALT + Click.
> That's correct, although I don't understand why. It feels simpler to have
> alt+click on all platforms, and I don't think alt+click is already bound to
> any other action.

As we discussed, listening for alt+click will also catch alt+ctrl+click anyway.  So this should be good to go as-is.
In fx-team: https://hg.mozilla.org/integration/fx-team/rev/8844503bc63a
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8844503bc63a
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Will, we've added a new shortcut on the markup view that allows expanding all child nodes by alt+clicking on the little arrow next to the node.
Keywords: dev-doc-needed
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.