Closed Bug 997713 Opened 7 years ago Closed 7 years ago

Regression: e.me topic pages contain no results

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S6 (25apr)

People

(Reporter: benfrancis, Assigned: kgrandon)

References

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review
STR:
* Type a non-URL string into Rocketbar
* Hit enter

Expected:
* Results for entered query

Actual:
* See a background image, but no results.

Alternative STR:
* Type "abc" into Rocketbar
* Select suggestion (e.g. "abc news")
There are a few bugs contributing to this regression. Bug 992884 impacts it a bit, at least as far as the query input updating goies.

There have also been some other patches landed that probably broke this as well. Seems like we really do need to spend some time adding some marionette tests here asap. I'll see if I can find a quick fix without backing things out, and if I can I will snag this.
Blocks: 992884
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Github pull request
Still needs some tests.
Comment on attachment 8409066 [details] [review]
Github pull request

Could either of you guys review this one? Thanks!
Attachment #8409066 - Flags: review?(dale)
Attachment #8409066 - Flags: review?(bfrancis)
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 1.4 S6 (25apr)
Comment on attachment 8409066 [details] [review]
Github pull request

Apologies, my bad, thanks for the fix
Attachment #8409066 - Flags: review?(dale)
Attachment #8409066 - Flags: review?(bfrancis)
Attachment #8409066 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/3fd5b86fa0cec7e8c0eccc95e1431b10934a6ee3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.