997713 - Regression: e.me topic pages contain no results

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Ben Francis [:benfrancis]]

STR:
* Type a non-URL string into Rocketbar
* Hit enter

Expected:
* Results for entered query

Actual:
* See a background image, but no results.

Alternative STR:
* Type "abc" into Rocketbar
* Select suggestion (e.g. "abc news")

Comment 1

[Kevin Grandon :kgrandon]

There are a few bugs contributing to this regression. Bug 992884 impacts it a bit, at least as far as the query input updating goies.

There have also been some other patches landed that probably broke this as well. Seems like we really do need to spend some time adding some marionette tests here asap. I'll see if I can find a quick fix without backing things out, and if I can I will snag this.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Still needs some tests.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8409066 [details] [review]
Github pull request

Could either of you guys review this one? Thanks!

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8409066 [details] [review]
Github pull request

Apologies, my bad, thanks for the fix

Comment 5

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/3fd5b86fa0cec7e8c0eccc95e1431b10934a6ee3