Closed Bug 997798 Opened 11 years ago Closed 11 years ago

Add strings in front page of /explore to locale

Categories

(Webmaker Graveyard :: webmaker.org, defect)

Product:
Webmaker Graveyard
Component:
webmaker.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kate, Assigned: akirose)

References

Details

(Whiteboard: explore, r2)

Attachments

(1 file, 1 obsolete file)

Fixes capitalisation bug, adds localisation strings
48 bytes, text/x-github-pull-request
kate
: review+
Details | Review
Most of them are just plain strings right now
Aki, can you help? Assigning to you for now.
Assignee: nobody → aki
Status: NEW → ASSIGNED
Note to self: make sure to address html entities here!
Attachment #8412828 - Flags: review?(kate)
Attachment #8412828 - Attachment is obsolete: true
Attachment #8412828 - Flags: review?(kate)
Attachment #8412849 - Flags: review?(kate)
Some issues with spacing on the front page here with localized strings https://www.dropbox.com/s/cx2z3mqjwx65leg/Screenshot%202014-04-25%2015.40.28.png Other than that looks good
Attachment #8412849 - Flags: review?(kate) → review-
How does this look? http://snaps.akibraun.com/cbm4z.png
Attachment #8412849 - Flags: review- → review?(kate)
Comment on attachment 8412849 [details] [review] Fixes capitalisation bug, adds localisation strings File a ticket for the spacing around the tools though https://www.dropbox.com/s/yog3j9g0hcux563/Screenshot%202014-04-25%2017.44.30.png
Attachment #8412849 - Flags: review?(kate) → review+
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/db462560cd51fc62f1802eff8c187005724322f0 fix Bug 997798 - Add strings in front page of /explore to locale https://github.com/mozilla/webmaker.org/commit/9ac49741c0407cc32b7f0b47132e74111e21d7bc Merge pull request #713 from gesa/997798 Bug 997798 - Add strings in front page of /explore to locale
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: