997814 - Make images responsive on front page of /explore

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[inactivate account for kate]

Right now they are all scaled 2x

Comment 1

[Cassie McDaniel [:cassiemc]]

Aki, can you help with this?

All images are here: https://www.dropbox.com/sh/p2qynqx4ar0d4d0/sllHpYFyKa

Comment 2

[Aki Rose Braun [:akirose]]

So we're not going to be using SVGs then? Those would probably scale a little better—and keep page load down.

Comment 3

[Cassie McDaniel [:cassiemc]]

We can use SVGs but Kate suggested pngs. Plus I'd have to recreate the events illustration because I did that in photoshop (dumb, I know). Can we use what's there now for mvp?

Comment 4

[Aki Rose Braun [:akirose]]

Definitely, I already started (I figured we'd need it for non-vector graphics anyway) but thought I'd check in. Definitely we should thing about adding that later though. (this is the kind of thing I can do too, I see it as the mundane, programmatic part of design. Recreating things in vector that is.)

Comment 5

[Aki Rose Braun [:akirose]]

Attachment: Adds retina image directive to make images respond to pixel ratio

Comment 6

[inactivate account for kate]

Comment on attachment 8410517 [details] [review]
Adds retina image directive to make images respond to pixel ratio

This looks great except for 1 nit

Comment 7

[inactivate account for kate]

Comment on attachment 8410517 [details] [review]
Adds retina image directive to make images respond to pixel ratio

1 style nit but R+

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/fbdd749c5bcf7fdd52f2cc979846b96068e05472
Bug 997814 - Make images responsive on front page of /explore

https://github.com/mozilla/webmaker.org/commit/8279a936945d5f9720c710c71c1c0e72860e295a
Merge pull request #692 from gesa/gesa/997814

Bug 997814 - Make images responsive on front page of /explore