997887 - Change Proxy API from PropertyDescriptor to PropDesc

Status: RESOLVED WONTFIX

(Core :: JavaScript: Standard Library, defect)

Description

[Eric Faust [:efaust]]

We have two property descriptor mechanisms, and it's silly. It's also causing us trouble. Let's update this.

Comment 1

[Jason Orendorff [:jorendorff]]

+1

Comment 2

[Eric Faust [:efaust]]

Attachment: Cleanup: Find a new home for PropDesc::unwrapDebuggerObjectsInto

If we're going to expose this stuff to embedders, we need to dust a little.

Comment 3

[Eric Faust [:efaust]]

Comment on attachment 8413074 [details] [diff] [review]
Cleanup: Find a new home for PropDesc::unwrapDebuggerObjectsInto

Moving to bug 1002737

Comment 4

[Eric Faust [:efaust]]

Attachment: getOwnPropertyDescriptor WIP

So, this is nowhere near complete, but here's enough to get the shell up and running and passing all jit-tests.

If it's agreeable, all that remains (for this operation), is to get the external proxy implementations on board.

This is a good point for a sanity check for size, intended side-effects, and engine-churn, though.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

What's the status here?

Comment 6

[Eric Faust [:efaust]]

I don't think we are even sure we want to do this. At very least, it's a Q1 goal of Jason's to clean up the second define property path, so this may be able to take a back seat until then, when it will probably not be that useful. The advent of JSPROP_IGNORE_* made this less important.

Comment 7

[Tom S [:evilpie]]

PropDesc was removed in bug 1133081.