997888 - Exclude sites from suggested sites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

To avoid having duplicate top and suggested sites in the grid.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Add API to exclude URLs from suggested sites (r=mfinkle)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: /1008210 - Exclude pinned/top sites from suggested sites (r=mfinkle)

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: /1008210 - Exclude pinned/top sites from suggested sites (r=mfinkle)

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8421695 [details] [diff] [review]
Add API to exclude URLs from suggested sites (r=mfinkle)

API + unit test.

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8421698 [details] [diff] [review]
/1008210 - Exclude pinned/top sites from suggested sites (r=mfinkle)

Change BrowserDB to use new API. The size of excludeUrls will, in practice, be between 5 and 8, pretty small. Using a simple list should be fine. I can micro-optimize it by using something like HashMap (bigger memory footprint) if you feel strongly about it.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8421698 [details] [diff] [review]
/1008210 - Exclude pinned/top sites from suggested sites (r=mfinkle)

Looks OK. I'm not too worried about the excludeUrls size, as longs as it stays in the <10 range.

These patches favor using the real thumbnail over the suggested thumbnail. We might decide to change that later; just a heads-up.

Also, how does this work with the new "privacy thumbnail" code? Sites that use "no-store" or are SSL will not get a real thumbnail. They just display a favicon+dominatcolor thumbnail. Will suggested thumbnails be used instead, if we have one?

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> Comment on attachment 8421698 [details] [diff] [review]
> /1008210 - Exclude pinned/top sites from suggested sites (r=mfinkle)
> 
> Looks OK. I'm not too worried about the excludeUrls size, as longs as it
> stays in the <10 range.
> 
> These patches favor using the real thumbnail over the suggested thumbnail.
> We might decide to change that later; just a heads-up.

Yeah, I'll tackle the overall image precedence behaviour in bug 1009587. Still needs some discussion. 

> Also, how does this work with the new "privacy thumbnail" code? Sites that
> use "no-store" or are SSL will not get a real thumbnail. They just display a
> favicon+dominatcolor thumbnail. Will suggested thumbnails be used instead,
> if we have one?

Nope. Right now we only show the suggested thumbnails on suggested sites. I'll change that based on what agree on in bug 1009587.

Comment 8

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/c5a13dbf3154
https://hg.mozilla.org/integration/fx-team/rev/6fb2da864ddf

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5a13dbf3154
https://hg.mozilla.org/mozilla-central/rev/6fb2da864ddf

Comment 10

[Ioana Chiorean]

Verified this on Latest Nightly (Fennec 33.0a1 ) and Aurora (Fennec 32.0a2)

Try to add one of the 4 suggested sites as pinned tab in top sites grid -> The suggested site will move int he position you choose to pin the URL.