997920 - Deactivate Rocketbar with cancel button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

The spec shows a cancel button in the focused state of the Rocketbar which should take the Rocketbar out of the focused state and go back to previous state.

Comment 1

[Ben Francis [:benfrancis]]

WIP patch https://github.com/benfrancis/gaia/commit/e180b60707bd8ed4943bf4a2578752dd969f16e8 needs tests and needs to wait for bug 993346 to land to work.

Comment 2

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/18539

Comment 3

[Ben Francis [:benfrancis]]

Fixed merge conflicts.

Comment 4

[Dale Harvey (:daleharvey)]

Cheers, I was waiting on 99346 to land before reviewing, will do now

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8410482 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18539

I believe from looking at the specs the divider line is supposed to have top and bottom padding not take up the full line-height (although its hard to see, the spec is blurry), and the right and left margins seem  off (left is smaller than the right margin, should be equal)

However we need to do a pass on exact visuals after user testing, this works great, so would be nice if you could get quick fixes for those in, if not its still best to get it in for testing

Comment 6

[Ben Francis [:benfrancis]]

Thanks for the review Dale, I could have sworn the visuals I saw didn't have padding there, but I have seen several different versions now.

We definitely need to make another pass on Rocketbar visuals in general as the specs have changed several times during implementation and many of the dimensions are now wrong anyway.

This is green on Travis and I think is probably ready to land as soon as the tree re-opens.

Comment 7

[Ben Francis [:benfrancis]]

Merged into master https://github.com/mozilla-b2g/gaia/commit/ceb0871838e45d4b813775e584d52d1edae4c1bb