997924 - [B2G]SMS notification is not received while the device is locked if it was locked while viewing the SMS thread

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

If the device is locked while viewing a SMS thread, there will be no notification if a SMS is received from the same number attached to the thread. The phone vibrates, but does not make any sound.

Repro Steps:
1) Update a Buri to BuildID: 20140417040206
2) Send a SMS to the DUT
3) View the message and lock the device while the thread is open
4) Send another SMS to the DUT from the same device used in step 2

Actual:
There is no notification received

Expected:
There is a notification received

1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140417040206
Gaia: dadf0e60a6421f5b57ee9fc536c6617212805c19
Gecko: c55dfb01a027
Version: 31.0a1
Firmware Version: V1.2-device.cfg

Repro frequency: 3/3, 100%
See attached: logcat

Comment 1

[Andrew Stole [:astole]]

This issue does not occur on the latest 1.4

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140417000204
Gaia: 00a9d55a3e7463cecfb5dde185c0ee1f4c4d9e54
Gecko: d3d40652aaa2
Version: 30.0a2
Firmware Version: V1.2-device.cfg

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

ni? julien/steve

Comment 3

[Julien Wajsberg [:julienw]]

Yes, I think the document.hidden property lies to us in that case. I think we have another bug that has the same cause, but didn't dig more than this yet.

Comment 4

[Steve Chung [:steveck]]

Like julien said, it should be a issue in document.hidden that the value still be false even the device is locked. Just note that 4/10 master build could not reproduce this issue.

Comment 5

[J Zimbrick]

b2g-inbound Regression Window:

Last Working Environmental Variables: 
Device: Buri
BuildID: 20140415002702
Gaia: 5576f4568618f4a57b887910fb2c6f00ea9d0d08
Gecko: acfc8089f7a2
Version: 31.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables: 
Device: Buri
BuildID: 20140415004202
Gaia: 7afce8a6e965a45f38988227828ccdfb315394f3
Gecko: 4f9f1be9e587
Version: 31.0a1
Base Image: V1.2-device.cfg

Last Working Gaia / First Broken Gecko: Issue does NOT occur.
Gaia: 5576f4568618f4a57b887910fb2c6f00ea9d0d08
Gecko: 4f9f1be9e587

First Broken Gaia / Last Working Gecko: Issue DOES occur.
Gaia: 7afce8a6e965a45f38988227828ccdfb315394f3
Gecko: acfc8089f7a2

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/5576f4568618f4a57b887910fb2c6f00ea9d0d08...7afce8a6e965a45f38988227828ccdfb315394f3

Comment 6

[Jason Smith [:jsmith]]

Does this reproduce on a Tarako device?

Caused by bug 990003.

Comment 7

[J Zimbrick]

This issue does reproduce on a Tarako device running the latest 1.3T build.

Environmental Variables:
Device: Tarako
BuildID: 20140418071327
Gaia: d185c05756e4bf366b1d9ac0c025909212c39f66
Gecko: cc89df9f6f30
Version: 28.1
Base Image: SP682la-4-18

Comment 8

[James Zhang (Spreadtrum)]

Is it the same as bug 995907?

Comment 9

[Julien Wajsberg [:julienw]]

James, I don't think so, bug 995907 was filed before bug 990003 landed.

This looks strange that bug 990003 provoked this... Can we try to reproduce on a 1.4 build, to have another proof?

Comment 10

[Julien Wajsberg [:julienw]]

Etienne, any clue?

Comment 11

[Jason Smith [:jsmith]]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> James, I don't think so, bug 995907 was filed before bug 990003 landed.
> 
> This looks strange that bug 990003 provoked this... Can we try to reproduce
> on a 1.4 build, to have another proof?

1.4 was already tested here - doesn't reproduce on 1.4.

Comment 12

[Julien Wajsberg [:julienw]]

Right, so yes, bug 990003 is very likely the culprit here. We'll need Etienne!

Comment 13

[Julien Wajsberg [:julienw]]

Back to system component because the change in the System app in bug 990003 triggered this bug.

Comment 14

[Etienne Segonzac (:etienne)]

Ok got it. We're not hiding the window because the preloaded callscreen must have an audio channel opened [1].
Working on a patch.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/visibility_manager.js#L65-75

Comment 15

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Comment 16

[Anthony Ricaud (:rik)]

Comment on attachment 8410176 [details] [review]
Gaia PR

One of the unit test is to update, see PR.

Comment 17

[Etienne Segonzac (:etienne)]

Comment on attachment 8410176 [details] [review]
Gaia PR

test udpated.

Comment 18

[Keven Kuo [:kkuo]]

Hi! James,

Check in needed. Thanks

--
Keven

Comment 19

[James Zhang (Spreadtrum)]

(In reply to Keven Kuo [:kkuo] from comment #18)
> Hi! James,
> 
> Check in needed. Thanks
> 
> --
> Keven

It's on master, I need v1.3t.

Comment 20

[Etienne Segonzac (:etienne)]

Apparently this got merged on master (hope travis was green), so resolved fix.

https://github.com/mozilla-b2g/gaia/commit/c0e3264cf1e57d2da3ce201554b620bd3cf01d24

Comment 21

[James Zhang (Spreadtrum)]

Please land it on v1.3t.

Comment 22

[Julien Wajsberg [:julienw]]

James, it will eventually go to 1.3+ once the people in charge of uplifts will do it today. No worry.

Comment 23

[Joe Cheng [:jcheng] (please needinfo)]

hi James, your team is also granted permission to do 1.3T gaia uplifts. Can your team simply does the uplift? and once you have done this, change the status1.3T to fixed. thanks

Comment 24

[ying.xu]

https://github.com/mozilla-b2g/gaia/commit/94de493682d56f22f25ecadd6434bd4f2555e643

Comment 25

[yang.zhao]

Already done.
commit id：94de493682d56f22f25ecadd6434bd4f2555e643

Comment 27

[James Zhang (Spreadtrum)]

(In reply to yang.zhao from comment #25)
> Already done.
> commit id：94de493682d56f22f25ecadd6434bd4f2555e643

land.

Comment 28

[Julien Wajsberg [:julienw]]

I'm sorry to be dense here, why isn't it possible to wait for the sheriff to do the uplift? I'm afraid of introducing bugs when someone that didn't write the patch tries to uplift to a branch in some code that he doesn't know, especially if there are conflicts (and I see there were some conflicts here).

For example, we can see that the uplift was not done using "-x", so we don't have the direct reference to the uplifted commit.

Comment 30

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Verified as fixed in today's build

1.3t Environmental Variables:
Device: Tarako 1.3t
BuildID: 20140428014001
Gaia: 8895b180ed636069473703d0e7b73086989601ce
Gecko: 7caf4b5abfce
Version: 28.1
Firmware Version: sp6821

Comment 31

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/38250fcbca0e3ae1ced0b4449a9c31a3d428d65e