997970 - add search suggest to Amazon for en-US

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

Amazon has given us a link [1] for search suggest for use in their search engine built into Firefox [2].

Can we add this only to the default en-US Amazon engine in Firefox?  Amazon has other links for other locales they would prefer we use and I will get those after we roll out with this version.

As we roll this out, is there a way to monitor usage via Telemetry and/or FHR?  Before full production release I would like to have a good idea of the expected load requirements.

Also it would be helpful to have a quick breakdown of the error codes responses that Firefox expects with search suggest in order to back off etc.

Thanks

[1] https://completion.amazon.com/search/complete?q={searchTerms}&search-alias=aps&mkt=1

[2] https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/amazondotcom.xml

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to Bryan Clark (Firefox Search PM) [:clarkbw] from comment #0)
> As we roll this out, is there a way to monitor usage via Telemetry and/or
> FHR?  Before full production release I would like to have a good idea of the
> expected load requirements.

We don't have any telemetry/FHR data on this at the moment.

> Also it would be helpful to have a quick breakdown of the error codes
> responses that Firefox expects with search suggest in order to back off etc.

This isn't very well documented, unfortunately, but I can link you to the code:

http://hg.mozilla.org/mozilla-central/annotate/9d3da41ad0b6/toolkit/components/search/nsSearchSuggestions.js#l54
http://hg.mozilla.org/mozilla-central/annotate/9d3da41ad0b6/toolkit/components/search/nsSearchSuggestions.js#l277

The quick summary is that if we receive 3 500/502/503 responses from the suggest server within 10 minutes, we enter a backoff mode until we get a successful request, or until the client is restarted. Backoff mode makes us delay the next request for 10 minutes, and if again see 3-failures-in-10-minutes, increasingly delay further requests (nextDelay = (currentDelay * 2)+10min).

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Removing this dependency, Amazon is ready to go live.

Comment 3

[Marco Mucci [:MarcoM]]

Hi Marco, can you mark this bug as either [qa+] or [qa-] for verification.

Comment 4

[Marco Bonardo [:mak]]

I think it's worth a qa check.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/0e734989df76

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0e734989df76

Comment 8

[Marco Mucci [:MarcoM]]

Hi Petruta, following up to see if this bug can be verified by the end of the iteration on Monday August 4.

Comment 9

[Petruta Horea [:phorea], Desktop QA]

Tested using Nightly 34.0a1 2014-07-29 under Win 7 64-bit, Ubuntu 12.10 32-bit and Mac OSX 10.9.4.

- Suggestions are displayed only in search toolbar (in url bar, about:home or search text field not)
- Suggestions are not shown all the time, sometimes space " " must be entered  
- If typing fast, suggestions doesn't appear

Please check if those are intended or not. Thank you!

Comment 10

[Marco Bonardo [:mak]]

(In reply to Petruta Rasa [QA] [:petruta] from comment #9)
> - Suggestions are displayed only in search toolbar (in url bar, about:home
> or search text field not)

we don't display search suggestions in the urlbar, we also don't yet display them in about:home (bug 612453). Not sure what you mean by search text field.
To be clear, the only place where today we show search suggestions is the search bar. So looks like we are fine.

> - Suggestions are not shown all the time, sometimes space " " must be
> entered  
> - If typing fast, suggestions doesn't appear

I can reproduce the latter with Google fwiw, so looks like it's a more general search servuce issue. I cannot reproduce the former, but I assume it might happen for some timing reasons, similarly to the other issue.
It's possible the amazon server is slower than google at answering and that exacerbates some existing race conditions. Might be worth filing a more general investigation bug to figure if we can reduce number of failures in providing suggestions, but that'd be for all engines, and unrelated to the addition of amazon.

Comment 11

[Petruta Horea [:phorea], Desktop QA]

Thanks for your quick answer.

Marking this as verified based on above comments.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Marco, could you fill an uplift request for aurora? Bryan would like to see that change in 33 and I am happy with that.

Comment 13

[Marco Bonardo [:mak]]

Comment on attachment 8461652 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: Amazon search suggestions
[User impact if declined]: no search suggestions
[Describe test coverage new/current, TBPL]: in Nightly, has test
[Risks and why]: very low
[String/UUID change made/needed]: none (just changing en-US search engine definition)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/857ef8da8a0e

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

Marco, could you also fill an uplift request for Beta? I checked in with Lawrence and he'd like it checked in by Monday to make beta6.  Thanks!

Comment 16

[Marco Bonardo [:mak]]

Comment on attachment 8461652 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: Amazon search suggestions
[User impact if declined]: no search suggestions for Amazon search engine
[Describe test coverage new/current, TBPL]: in Nightly and Aurora, has test
[Risks and why]: very low
[String/UUID change made/needed]: none (just changing en-US search engine definition)

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8461652 [details] [diff] [review]
patch v1

Approved on the behalf of Lawrence.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f7ae08da07f

Comment 19

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Marking for verification in Aurora 33 and Beta 32.

Comment 20

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 32 beta 6 (20140811180644) and Aurora 33.0a2 2014-08-10 under Win 8 32-bit, Ubuntu 13.04 64-bit and Mac OSX 10.7.5.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 22

[Sylvestre Ledru [:Sylvestre]]

A bit too late to be part of the 32 release notes...