998137 - When Passcode is disabled, give more room to the date/time

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Théo Chevalier]

Currently, whether Passcode is enabled or not (so, whether Camera icon is displayed next to the date or not), the space allowed for the date remains the same.

As a little improvement, we could give more room to the date when Passcode is disabled. (It's visually better for locales requiring a lot of space to display the date correctly.)

Comment 1

[Francesco Lodolo [:flod]]

Théo, I think this is not an issue anymore with the current design (camera moved to the unlock section at the bottom). Can you confirm?

Comment 2

[Théo Chevalier]

Attachment: Date goes on a new line on passcode screen (expected)

Not sure what you mean, I still see the Camera icon on the right. Are you talking about something that landed like this night?

Comment 3

[Théo Chevalier]

Attachment: Date goes on a new line on lockscreen (unexpected)

Comment 4

[Francesco Lodolo [:flod]]

Thanks, with screenshots comment 0 is a lot clearer :-)

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Test patched

Kind of hard to reproduce, since I can't access that part of the DOM with devtools.

Camera button is floated right
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/lockscreen/lockscreen.css#L342

And hidden on [data-panel="main"]
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/lockscreen/lockscreen.css#L159

But that still uses up space. Using position absolute on the hidden element should get free space for the date, only downside the date "moves" (wraps) when you unlock the screen.

Comment 6

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

I've tried to test the patch, but it didn't work, or maybe I misunderstand what the patch does.
Since I don't have the language which can show the date string so long, I connect to app manager and change the English date line longer to see the effect.

You can see in the screenshot the date string still got wrapped near the camera icon. And for no wrapping case, no mater whether the absolute line is added or not, the date line would occur to the end of screen.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: long date string

Comment 9

[Théo Chevalier]

Comment on attachment 8457734 [details]
long date string

This behavior is probably expected, because "WednesdayWednesday" can't fit on the remaining space.
I guess if you try with "Day day day day day day day day day day day" instead, it will work.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8456859 [details] [review]
Pull request on Github

OK, while I feel it's nice to land this feature (code level). Let's wait the possible UX review and opinions in the future (since visual refreshing is on going).

Comment 11

[Francesco Lodolo [:flod]]

Greg, any suggestion on whom should be flagged for ux review?

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

You can set the ui-review to Amy Lee, who now is the major designer of new LockScreen visual refresh.

Comment 13

[Francesco Lodolo [:flod]]

Comment on attachment 8456859 [details] [review]
Pull request on Github

Thanks Greg, setting flag for ui-review.

Comment 14

[Amy Lee [:amylee] UX]

Comment on attachment 8456859 [details] [review]
Pull request on Github

Hi, 

It's hard for me to check the patch since I can't get it to have a long enough string. Can you send me a screenshot of the two scenarios:

1. When there is a long string for date in lockscreen
2. When there is a long string for date in lockscreen with pin code

Thanks!

Comment 15

[Francesco Lodolo [:flod]]

Hi Amy, have you seen the current attachments?

With the patch and a long (fake) string, with or without passcode (note that the behavior with passcode doesn't change, the only change is when passcode is not displayed and there's no camera icon)
https://bug998137.bugzilla.mozilla.org/attachment.cgi?id=8456858

Current behavior with a different long string
https://bug998137.bugzilla.mozilla.org/attachment.cgi?id=8456354

Comment 16

[Amy Lee [:amylee] UX]

(In reply to Francesco Lodolo [:flod] from comment #15)
> Hi Amy, have you seen the current attachments?
> 
> With the patch and a long (fake) string, with or without passcode (note that
> the behavior with passcode doesn't change, the only change is when passcode
> is not displayed and there's no camera icon)
> https://bug998137.bugzilla.mozilla.org/attachment.cgi?id=8456858
> 
> Current behavior with a different long string
> https://bug998137.bugzilla.mozilla.org/attachment.cgi?id=8456354

Hi Francesco, 

Can you show me a screenshot with the notifications on the lockscreen as well? I just want to make sure that the notifications don't overlap with the date when it's on two lines.

It looks like this is a flame device screenshot. Do you have a 320x480 screen sized device as well to make sure there is enough space for notifications and the date if it goes into two lines. 

Thanks!

Comment 17

[Théo Chevalier]

Attachment: Long date, no passcode + notification (Buri 2.1 w/ patch)

Hi Amy,
please find the two screenshots on Buri with notification.
Let me know if you need anything else

Comment 18

[Théo Chevalier]

Attachment: Long date, passcode enabled + notification (Buri 2.1 w/ patch)

Comment 19

[Théo Chevalier]

Attachment: FMD locked screen

Do we want to handle that case?

Comment 20

[Francesco Lodolo [:flod]]

(In reply to Théo Chevalier [:tchevalier] from comment #19)
> Do we want to handle that case?

FMD = Find My Device?

If we want, I'd suggest to file a follow-up and let the module owner or peer take care of it. Looking at the screen, I'm not even sure we're not broken with date on one line.

Comment 21

[Théo Chevalier]

(In reply to Francesco Lodolo [:flod] from comment #20)
> (In reply to Théo Chevalier [:tchevalier] from comment #19)
> > Do we want to handle that case?
> 
> FMD = Find My Device?

Yes, sorry :)

> 
> If we want, I'd suggest to file a follow-up and let the module owner or peer
> take care of it. Looking at the screen, I'm not even sure we're not broken
> with date on one line.

Yes, probably a follow-up. However, not sure what's broken on one line

Comment 22

[Francesco Lodolo [:flod]]

(In reply to Théo Chevalier [:tchevalier] from comment #21)
> Yes, probably a follow-up. However, not sure what's broken on one line

Camera icon is floated to the right. Notification is slight overlapping the bottom of camera icon, which means is either using negative margins, or absolute positioning, and I don't think that changes with shorter dates.

Comment 23

[Amy Lee [:amylee] UX]

Comment on attachment 8456859 [details] [review]
Pull request on Github

Hi, 

Thanks for sending over the screenshots. This looks okay to me.

Comment 24

[Francesco Lodolo [:flod]]

Thanks, setting keyword for checkin.

Comment 25

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/df5e2e7da933a9c605d8ae7d31a7215a4d6d7e48

Comment 26

[Francesco Lodolo [:flod]]

Verified on flame

Gaia      c8511217183ade630f5afa7698c04efef5c6806b
Gecko     https://hg.mozilla.org/mozilla-central/rev/a4dcfbebcb58
BuildID   20140728040209
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014