Closed
Bug 998167
Opened 11 years ago
Closed 11 years ago
Fix signed integer overflow in EvaluateConstantOperands
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: sunfish, Assigned: sunfish)
Details
Attachments
(1 file)
|
1.43 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
The code in EvaluateConstantOperands for folding an Lsh operator uses a signed left shift. This invokes undefined behavior if the computation overflows.
|
Assignee | |
Comment 1•11 years ago
|
||
This patch changes Lsh to use an unsigned shift instead of a signed shift to fix the undefined behavior, and also tidies up the Ursh case to look similar.
Assignee: nobody → sunfish
Attachment #8408725 -
Flags: review?(nicolas.b.pierron)
|
||
Updated•11 years ago
|
Attachment #8408725 -
Flags: review?(nicolas.b.pierron) → review+
|
||
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•