Privacy policy url has changed

VERIFIED FIXED in Firefox 32

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Swarnava, Assigned: biraj, Mentored)

Tracking

unspecified
Firefox 32
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=xul])

Attachments

(1 attachment, 1 obsolete attachment)

In Firefox, the privacy policy link is https://www.mozilla.org/legal/privacy/

The url for the privacy policy has changed from https://www.mozilla.org/legal/privacy/ to https://www.mozilla.org/privacy/

i guess we should update it?
Duplicate of this bug: 999421
Assignee: nobody → brnet00
Whiteboard: [good first bug][lang=xul][mentor=manishearth]
*pokes bug*
I am working on this bug .
Posted patch bug-998207.patch (obsolete) — Splinter Review
Patch added .
Attachment #8410368 - Flags: feedback?(manishearth)
Comment on attachment 8410368 [details] [diff] [review]
bug-998207.patch

Review of attachment 8410368 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, aside from the nit below.

We'll wait for a response from #www before asking for r on this.

::: browser/base/content/aboutDialog.xul
@@ +143,5 @@
>        </hbox>
>        <description id="trademark">&trademarkInfo.part1;</description>
>      </vbox>
>    </vbox>
>    

You accidentally added some whitespace here, please remove it.
Attachment #8410368 - Flags: feedback?(manishearth) → feedback+
Added now !
Attachment #8410368 - Attachment is obsolete: true
Attachment #8410381 - Flags: feedback?(manishearth)
Comment on attachment 8410381 [details] [diff] [review]
bug-998207_final.patch

Review of attachment 8410381 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for the patch.

(Again, waiting on confirmation from #www)
Attachment #8410381 - Flags: feedback?(manishearth) → feedback+
Mike, could you have a look at this and let us know if it's necessary?

Basically *should* Firefox point to the /en-US/ URL or the /legal/ URL?

Thanks.
Flags: needinfo?(malexis)
(In reply to Manish Goregaokar [:manishearth] from comment #8)
> Mike, could you have a look at this and let us know if it's necessary?
> 
> Basically *should* Firefox point to the /en-US/ URL or the /legal/ URL?
> 
> Thanks.

Sorry for the late reply. Yes, it's OK to change that link to https://www.mozilla.org/privacy/
Flags: needinfo?(malexis)
@mike: thanks for your reply . Could you please commit the patch? i have already submitted it.
Flags: needinfo?(malexis)
(In reply to Biraj Karmakar [:biraj] from comment #10)
> @mike: thanks for your reply . Could you please commit the patch? i have
> already submitted it.

I'm on web productions and work on mozilla.org. Someone from Firefox engineering will have to do the commit.

Dao, can you advise?
Flags: needinfo?(malexis) → needinfo?(dao)
@Biraj, for patches to Firefox, just mark the patch for review, by going to the Details pane and setting the review? flag. I'll do this for you this time :)
Flags: needinfo?(dao)
Attachment #8410381 - Flags: review?(dao)
Comment on attachment 8410381 [details] [diff] [review]
bug-998207_final.patch

thanks!
Attachment #8410381 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/ec02487ed239

Thanks for the patch, Biraj! I pushed it with a small tweak to the commit message. In general, the commit message should be saying what the patch is doing, not restating the problem it's solving. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment
Keywords: checkin-needed
Whiteboard: [good first bug][lang=xul][mentor=manishearth] → [good first bug][lang=xul][mentor=manishearth][fixed-in-fx-team]
Thanks Mike,dao,manishearth,ryan
https://hg.mozilla.org/mozilla-central/rev/ec02487ed239
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=xul][mentor=manishearth][fixed-in-fx-team] → [good first bug][lang=xul][mentor=manishearth]
Target Milestone: --- → Firefox 32
Status: RESOLVED → VERIFIED
Mentor: manishearth
Whiteboard: [good first bug][lang=xul][mentor=manishearth] → [good first bug][lang=xul]
You need to log in before you can comment on or make changes to this bug.