998207 - Privacy policy url has changed

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Swarnava Sengupta (:Swarnava)]

In Firefox, the privacy policy link is https://www.mozilla.org/legal/privacy/

The url for the privacy policy has changed from https://www.mozilla.org/legal/privacy/ to https://www.mozilla.org/privacy/

i guess we should update it?

Comment 2

[Manish Goregaokar [:manishearth]]

*pokes bug*

Comment 3

[Biraj Karmakar [:biraj]]

I am working on this bug .

Comment 4

[Biraj Karmakar [:biraj]]

Attachment: bug-998207.patch

Patch added .

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8410368 [details] [diff] [review]
bug-998207.patch

Review of attachment 8410368 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, aside from the nit below.

We'll wait for a response from #www before asking for r on this.

::: browser/base/content/aboutDialog.xul
@@ +143,5 @@
>        </hbox>
>        <description id="trademark">&trademarkInfo.part1;</description>
>      </vbox>
>    </vbox>
>    

You accidentally added some whitespace here, please remove it.

Comment 6

[Biraj Karmakar [:biraj]]

Attachment: bug-998207_final.patch

Added now !

Comment 7

[Manish Goregaokar [:manishearth]]

Comment on attachment 8410381 [details] [diff] [review]
bug-998207_final.patch

Review of attachment 8410381 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for the patch.

(Again, waiting on confirmation from #www)

Comment 8

[Manish Goregaokar [:manishearth]]

Mike, could you have a look at this and let us know if it's necessary?

Basically *should* Firefox point to the /en-US/ URL or the /legal/ URL?

Thanks.

Comment 9

[Mike Alexis [:malexis]]

(In reply to Manish Goregaokar [:manishearth] from comment #8)
> Mike, could you have a look at this and let us know if it's necessary?
> 
> Basically *should* Firefox point to the /en-US/ URL or the /legal/ URL?
> 
> Thanks.

Sorry for the late reply. Yes, it's OK to change that link to https://www.mozilla.org/privacy/

Comment 10

[Biraj Karmakar [:biraj]]

@mike: thanks for your reply . Could you please commit the patch? i have already submitted it.

Comment 11

[Mike Alexis [:malexis]]

(In reply to Biraj Karmakar [:biraj] from comment #10)
> @mike: thanks for your reply . Could you please commit the patch? i have
> already submitted it.

I'm on web productions and work on mozilla.org. Someone from Firefox engineering will have to do the commit.

Dao, can you advise?

Comment 12

[Manish Goregaokar [:manishearth]]

@Biraj, for patches to Firefox, just mark the patch for review, by going to the Details pane and setting the review? flag. I'll do this for you this time :)

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 8410381 [details] [diff] [review]
bug-998207_final.patch

thanks!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ec02487ed239

Thanks for the patch, Biraj! I pushed it with a small tweak to the commit message. In general, the commit message should be saying what the patch is doing, not restating the problem it's solving. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 15

[Biraj Karmakar [:biraj]]

Thanks Mike,dao,manishearth,ryan

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec02487ed239