998242 - Move single mozmill tests into a subdirectory

Status: RESOLVED WORKSFORME

(Calendar :: General, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

We should move the single mozmill tests into subdirs so they are grouped and separate from the Thunderbird tests when packaged.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

What do you think of this structure?

Comment 2

[Markus Adrario [:Taraman]]

Comment on attachment 8408843 [details] [diff] [review]
Fix - v1

Review of attachment 8408843 [details] [diff] [review]:
-----------------------------------------------------------------

So far so good, I wonder, if "calendar-frontend" may be too general.
If we get more mozmill-tests for every area, then this directory might get a bit crowded. We already have one for the eventDialog itself and in fact, all mozmill tests use the frontend.
So I would prefer to keep the tests in smaller groups. Maybe we could add a directory "general-ui" or so for the Today-pane, the calendars-sidebar and general menus testing. The views and dialogs could then get an own directory (or even morethan one).

Therefore for the moment r-

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Yes, I wasn't too happy about the name here either. My plan was to move things around again as the number of tests increase, but you are right: why break up the existing group now.

I prefixed it with "calendar" because in the packaged tests they will be mixed with the Thunderbird tests, so general-ui will be too....general :-)

Your hint with calendar-sidebars actually brought me to this patch. We have more sidebar elements (the calendar list, minimonth and task filter) that might deserve a mozmill test in the future.

How is this one?

Comment 4

[Markus Adrario [:Taraman]]

Comment on attachment 8411307 [details] [diff] [review]
Fix - v2

you will have to change the paths to shared-modules in the 4 tests from "./shared-modules" to "../shared-modules"

therefore r- for now

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Do I have to do so both for RELATIVE_ROOT and the require() statement? I can't check since my mozmill tests are not running at all in the build env (it usually works in packaged tests).

Comment 6

[Markus Adrario [:Taraman]]

For the time you need to change both.
The require statement will disappear as soon as I adapt these tests to the new test-Calendar-Utils

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Waiting for bug 1020574 before I continue on this one.

Comment 8

[Markus Adrario [:Taraman]]

bug 1020574 finally landed, so how about progressing on this one?

I could take over if you like.

Comment 9

[Magnus Melin [:mkmelin]]

mozmill is gone. I don't think any action is required here.