Closed Bug 998287 Opened 10 years ago Closed 7 years ago

[Messages] Check whether we need to call both 'done' and 'end' in MessageManager.getThreads

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: azasypkin, Unassigned)

Details

Follow-up from bug 988711. Excerpt from github comment https://github.com/mozilla-b2g/gaia/pull/18175#discussion_r11768445:

> Reading how it's called and used, I don't think it's necessary to have
> both end and done in getThreads; it's useful in getMessages but not in getThreads.
> Currently, we use both but without really thinking about what's happening.

Also what should we show to the user if an error has occurred while retrieving threads?
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.