998298 - update DOM microdata tests from upstream

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Nathan Froyd [:froydnj]]

...which we don't allow in the new external-connections-are-bad world.

Actually, I think fixing this is as simple as putting http://example.net:80 in build/pgo/server-locations.txt.  This is documented in RFC 2606 as a reserved "example" domain, so there's no harm in having our proxy catch it.

Right around here is the correct location:

http://mxr.mozilla.org/mozilla-central/source/build/pgo/server-locations.txt#63

Comment 1

[Nathan Froyd [:froydnj]]

(According to try, this bug strangely only happens in e10s mochitests...)

Comment 2

[James Graham [:jgraham]]

That's the wrong fix. The right fix is to fix the tests upstream where the autoproxy stuff isn't part of the expected test environment. This is still a Good First Bug, but maybe I am a better mentor? Alternatively if this is causing problems I can fix it right away.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to James Graham [:jgraham] from comment #2)
> That's the wrong fix. The right fix is to fix the tests upstream where the
> autoproxy stuff isn't part of the expected test environment. This is still a
> Good First Bug, but maybe I am a better mentor? Alternatively if this is
> causing problems I can fix it right away.

Eh, I don't know that using example.net is necessarily wrong.  (Do the upstream tests necessarily have this no-external-connections policy?)  It seems like an oversight to not have it set up in our server-locations.txt, though.

But whichever: if you'd like to alter the bug to focus on fixing the tests and mentor that, please do.  If you'd like to fix server-locations.txt, please do.

The bug isn't causing problems right now, but it is one of a handful of bugs that prevent enforcing no-external-connections-during-tests.  So it'd be better to fix it sooner rather than later.

Comment 4

[James Graham [:jgraham]]

Upstream has the same policy for the same reason. The test needs to be fixed one way or another.

Comment 5

[Nathan Froyd [:froydnj]]

James, since there hasn't been a biter on the good first bug, are you able to fix this up?  This is one of the last bugs blocking bug 995417.

Comment 6

[James Graham [:jgraham]]

Sure.

Comment 7

[James Graham [:jgraham]]

Upstream review: https://critic.hoppipolla.co.uk/r/1503

Comment 8

[James Graham [:jgraham]]

Fixed upstream, just need Ms2ger to refresh the import.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Automatic import is broken, because the MANIFEST files are out of date. Someone will need to apply the change manually.

Comment 10

[Nathan Froyd [:froydnj]]

We wound up adding example.net to server-locations.txt for a different bug, so this bug no longer blocks putting external network protections in place.  Morphing.

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.