Closed Bug 998299 Opened 12 years ago Closed 12 years ago

Add Neo layout

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, enhancement)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: raniere, Assigned: raniere)

Details

Attachments

(1 file)

neo-layout
46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review
Want to add Neo layout [1] to available keyboards. [1] http://www.neo-layout.org/
Attached file neo-layout —
Attachment #8408950 - Flags: review?(rlu)
Comment on attachment 8408950 [details] [review] neo-layout Basically this looks good to me, so giving the r+ with some nits to be addressed. However, I also found some issues when long pressing on "o" to show the alternative char menu, which might be an issue of our implementation, not caused by this patch.
Attachment #8408950 - Flags: review?(rlu) → review+
Assignee: nobody → ra092767
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated attachment as requested.
Rudy, could you please merge the commit in order to allow Raniere to realize how we close an issue on bugzilla? Thank you very much.
Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/6088316e189e02cdf0ead472e64531c426b6f73e Sorry for the delay, next time could you please use needinfo? so that I'll respond as soon as I can. Thank you.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: