998724 - Feed preview is broken on SeaMonkey nightly

Status: RESOLVED FIXED

(SeaMonkey :: Feed Discovery and Preview, defect)

Description

[Masatoshi Kimura [:emk]]

Messages from the Error Console:
> Timestamp: 2014/04/20 9:31:31
> Error: Error: Permission denied to access property 'appendChild'
> Source File: resource://gre/components/FeedWriter.js
> Line: 968
> Timestamp: 2014/04/20 9:26:05
> Error: NS_ERROR_FAILURE: Failure
> Source File: chrome://communicator/content/feeds/subscribe.xml
> Line: 35

Comment 1

[Masatoshi Kimura [:emk]]

works: http://hg.mozilla.org/mozilla-central/rev/74a617a50287
broken: http://hg.mozilla.org/mozilla-central/rev/ec8a5ce1d620

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Port bug 986730 part 3: Run the FeedWriter sandbox with an expanded principal

Comment 3

[[e-mail]]

Attachment: Yak shaving

I've always wanted to rip out that sandbox, now here's my chance.

Comment 5

[Masatoshi Kimura [:emk]]

Doesn't it regress bug 360529?

Comment 6

[[e-mail]]

(In reply to Masatoshi Kimura from comment #5)
> Doesn't it regress bug 360529?

None of the test cases in that bug did anything when I tried them. (I think they're supposed to alert some privileged information?)

Mind you, most of this stuff predates X-rays, so it's ancient.

Comment 7

[Ian Neal]

Comment on attachment 8409421 [details] [diff] [review]
Yak shaving

>+++ b/suite/feeds/src/FeedWriter.js

>   _setContentText: function setContentText(id, text) {
>+    this._document.getElementById(id).textContent = text;
>   },
Has this been left for add-on support as it is not used in the current patch (yet).

I also noticed that the Firefox version of this did some stuff with supporting XHTML in feed titles, see changeset http://hg.mozilla.org/mozilla-central/rev/e3126e00ec91
Should we doing this as part of this patch too?

r=me with those addressed.

Comment 8

[[e-mail]]

Attachment: Updated for review comments

I meant to remove _setContentText but I restored it to make it easier to port bug 436801 (which I didn't do that here because I have no test case).

Comment 9

[Ian Neal]

Comment on attachment 8413443 [details] [diff] [review]
Updated for review comments

r=me

Comment 11

[[e-mail]]

Pushed comm-central changeset 7a929459a778.

Comment 12

[[e-mail]]

Comment on attachment 8413443 [details] [diff] [review]
Updated for review comments

[Approval Request Comment]
Regression caused by (bug #): 986730
User impact if declined: Feed preview does not work
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Could use attachment 8409410 [details] [diff] [review] instead.
String changes made by this patch: None

Comment 13

[[e-mail]]

https://hg.mozilla.org/releases/comm-aurora/rev/ba9979c7444c