Closed Bug 998776 Opened 6 years ago Closed 6 years ago

[Follow up of Bug 991446] Fix the broken coverage result on console

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(4 files, 4 obsolete files)

Bug 991446 only fix broken coverage result on Gaia PR, it should fix both Gaia and Js-test-agent. So this bug is created for fetching up the Bug 991446.
Summary: Follow up of Bug 991446 - fix the broken coverage result on console → [Follow up of Bug 991446] Fix the broken coverage result on console
Attached file Gaia PR (obsolete) —
Yuren, this is a follow-up bug of bug 991446 which you reviewed before.
So, I think it's more suitable for you to review.
Attachment #8410026 - Flags: review?(yurenju.mozilla)
Attached file Js-test-agent PR (obsolete) —
Attachment #8410027 - Flags: review?(yurenju.mozilla)
Attached file Gaia-node-modules PR (obsolete) —
Attachment #8410028 - Flags: review?(yurenju.mozilla)
Comment on attachment 8410027 [details] [review]
Js-test-agent PR

basically this pr is same as bug 991446 but for console reporter. r=yurenju
Attachment #8410027 - Flags: review?(yurenju.mozilla) → review+
Attachment #8410028 - Flags: review?(yurenju.mozilla) → review+
Attachment #8410026 - Flags: review?(yurenju.mozilla) → review+
Merged for update gaia_node_modules.revision

https://github.com/mozilla-b2g/gaia/commit/0814a85e335006475d995212691545af87e97185
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Hmm, seems this started causing tests to fail: https://tbpl.mozilla.org/php/getParsedLog.php?id=38375867&tree=B2g-Inbound

https://github.com/mozilla-b2g/gaia/commit/e24df48ff270695387d4811a4e19c7d79d70a734

I suppose it's time for more policies because gaia-node-modules has been breaking our CI often. We should probably ensure travis and gaia-try is green before landing next.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
NOOOOOOOOOOOOOO
Comment on attachment 8410028 [details] [review]
Gaia-node-modules PR

Please be informed I also reverted the changes to gaia-node-modules repo,
https://github.com/mozilla-b2g/gaia-node-modules/commit/5d67c410243c3928bfc5d143aba601b2e8fe513a

This is because I have to update marionette-apps for Bug 997045.
Depends on: 1001224
Not sure what the current status of this one is, but gaia-node-modules should now be fixed. Please check with Rudy to ensure comment 11 is not an issue. Thanks!
Attached file Gaia PR
Attachment #8410026 - Attachment is obsolete: true
Attached file Gaia-node-modules PR
Attachment #8410028 - Attachment is obsolete: true
@Kevin, do you think whether we have to push to try server again before landing?

If it is necessary, could you help me push to try server, or we can land it without this try? :)
Flags: needinfo?(kgrandon)
I think it should be ok as long as travis is green. Let's go ahead and land, but please make sure to update gaia_node_modules.revision at the same time you update package.json. Thanks!
Flags: needinfo?(kgrandon)
Attached file Js-test-agent PR
Attachment #8410027 - Attachment is obsolete: true
Attachment #8411531 - Attachment is obsolete: true
Merged Gaia PR - update node_modules revision.

https://github.com/mozilla-b2g/gaia/commit/bbc8d6a82dfd3d3575b918b4b43499cb135b5e7d
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.