998809 - WidgetEvent::typeString is not always set correctly

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Test

Event::GetType sets typeString, but Event::initEvent doesn't update it. This causes issues when calling .initEvent() / .type / .initEvent() / .type; see test.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Hmm, we used to clear typeString

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8437916 [details] [diff] [review]
patch

Sorry, I missed this request.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/287aa2e3cab0

Comment 5

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like 
https://tbpl.mozilla.org/php/getParsedLog.php?id=41785327&tree=Mozilla-Inbound
and
https://tbpl.mozilla.org/php/getParsedLog.php?id=41783394&tree=Mozilla-Inbound

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Whaaat?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Pushed to try. Couldn't reproduce the mochitest error locally.
(and don't really see how the patch could have caused those errors.)

https://tbpl.mozilla.org/?tree=Try&rev=f3b344d2c384

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6bfb8e486881

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6bfb8e486881