Closed
Bug 998809
Opened 10 years ago
Closed 10 years ago
WidgetEvent::typeString is not always set correctly
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: Ms2ger, Assigned: smaug)
Details
Attachments
(2 files)
490 bytes,
text/html
|
Details | |
2.26 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
Event::GetType sets typeString, but Event::initEvent doesn't update it. This causes issues when calling .initEvent() / .type / .initEvent() / .type; see test.
Assignee | ||
Comment 1•10 years ago
|
||
Hmm, we used to clear typeString
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bugs
Assignee | ||
Updated•10 years ago
|
Attachment #8409482 -
Attachment mime type: text/plain → text/html
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8437916 -
Flags: review?(masayuki)
Comment 3•10 years ago
|
||
Comment on attachment 8437916 [details] [diff] [review] patch Sorry, I missed this request.
Attachment #8437916 -
Flags: review?(masayuki) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/287aa2e3cab0
Comment 5•10 years ago
|
||
sorry had to back this out for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=41785327&tree=Mozilla-Inbound and https://tbpl.mozilla.org/php/getParsedLog.php?id=41783394&tree=Mozilla-Inbound
Assignee | ||
Comment 6•10 years ago
|
||
Whaaat?
Assignee | ||
Comment 7•10 years ago
|
||
Pushed to try. Couldn't reproduce the mochitest error locally. (and don't really see how the patch could have caused those errors.) https://tbpl.mozilla.org/?tree=Try&rev=f3b344d2c384
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bfb8e486881
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6bfb8e486881
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•