998918 - SIM lock error message is not properly shown after we enter invalid PIN code

Status: RESOLVED DUPLICATE of bug 1007948

(Firefox OS Graveyard :: RIL, defect)

Description

[Sharaf]

STR

* Enable SIM PIN security
* Restart the device
* After restart, when prompted for SIM PIN enter invalid no and press "done"
* Its observed that the error message is flashed and screen is reset

Comment 1

[Sharaf]

It seems this issue is due to Bug #965765.

when "unlockCardLock" fails, "iccinfochange" is raised and it resets the SIM PIN Dialog.

If I add 

    if(SimPinDialog.visible) {
      return false;
    }

in showIfLocked the message is properly shown.

Please comment. If this is okey, I can upload a patch.

Comment 2

[:gerard-majax]

(In reply to Sharaf from comment #0)
> STR
> 
> * Enable SIM PIN security
> * Restart the device
> * After restart, when prompted for SIM PIN enter invalid no and press "done"
> * Its observed that the error message is flashed and screen is reset

I don't understand the behavior you are exposing. It's unclear what happens, can you provide video/screenshots?

Comment 3

[Sharaf]

I will try to upload a video, but I feel STR is clear enough :-(

in SIM PIN unlock screen if you give invalid value, the error message "You have XX tries left to enter the correct code before locking the SIM card" in Red is shown for a fraction of second.

Comment 4

[:gerard-majax]

(In reply to Sharaf from comment #3)
> I will try to upload a video, but I feel STR is clear enough :-(
> 
> in SIM PIN unlock screen if you give invalid value, the error message "You
> have XX tries left to enter the correct code before locking the SIM card" in
> Red is shown for a fraction of second.

That was not clear. So it means the error message disappears after being correctly displayed.

Comment 5

[Sharaf]

Yes. Before Bug #965765 the message stays there as a warning to the user.
You still want video?

Comment 6

[:gerard-majax]

I'm not able to reproduce this on my B2G Desktop with JS libril. Please document the device and builds infos.

Comment 7

[Sharaf]

I am trying this on a leo device
Gaia master commit ac3eba60d22e1cceeaefdc3f175d698506e9c990 (pulled today)

Comment 8

[:gerard-majax]

(In reply to Sharaf from comment #7)
> I am trying this on a leo device
> Gaia master commit ac3eba60d22e1cceeaefdc3f175d698506e9c990 (pulled today)

And what is the gecko running?

I'm sorry but I don't have any working leo to check this.

Comment 9

[Sharaf]

gecko I have is 00bcafd092d649be3385b9e89bbed999f74c6045

Comment 10

[:gerard-majax]

(In reply to Sharaf from comment #9)
> gecko I have is 00bcafd092d649be3385b9e89bbed999f74c6045

That makes quite a strange combination. I believe your Gecko is not a master (end of february, before the branching) ; we only support gecko and gaia to be tracking the same version.

Comment 11

[:gerard-majax]

Please try to reproduce this on a set of matching Gecko and Gaia, I know there has been some work on both Gecko and Gaia side that impacts RIL features, due to DSDS support. You may fall into a creepy state there, because of the differences between your gecko and gaia.

Comment 12

[:gerard-majax]

FYI the JS libril hack is available at https://github.com/lissyx/mozilla-central/tree/libril-bug989926

Doing a git clone of this repo, then checking out this branch, you can build a gecko with a facked RILd that can be hacked in JS. You would need to make sure your .mozconfig has the following:

> mk_add_options MOZ_OBJDIR=obj-libril
> ac_add_options --enable-b2g-ril
> ac_add_options --enable-application=b2g
> ac_add_options --with-ccache

Then just build this B2G Desktop (with |./mach build|), run it with a gaia production profile. The JS libril code is located in b2g/chrome/content/libril.js. Each time you make changes to this file, re-run |./mach build b2g/|, then you can relaunch B2G Desktop.

If you can either directly reproduce this bug, or hack libril.js to expose it, then we may be able to do some good :)

Comment 13

[Sharaf]

I tried with gecko commit 520cce8dd0319be61bfaab10908b9458922e7aa5 also.
The issue exists.
(with same gaia as in comment #7)

Comment 14

[:gerard-majax]

I'm sorry, but:

> $ git branch -a --contains 520cce8dd0319be61bfaab10908b9458922e7aa5
>   remotes/origin/v1.3
>   remotes/origin/v1.3t

> $ git branch -a --contains ac3eba60d22e1cceeaefdc3f175d698506e9c990
> * master
>   remotes/origin/HEAD -> origin/master
>   remotes/origin/master

Looks like you are using a Gecko for v1.3 and a Gaia master (2.0 to become)

Comment 15

[Sharaf]

I have one device with gecko commit d0849cfd3c632a0bb60df28567d48fc01dae387c with Gaia master.
Unfortunately in that device also issue is reproduced. :-(

Comment 16

[:gerard-majax]

(In reply to Sharaf from comment #15)
> I have one device with gecko commit d0849cfd3c632a0bb60df28567d48fc01dae387c
> with Gaia master.
> Unfortunately in that device also issue is reproduced. :-(

This one would be a legit gecko master. Can you document Gecko RIL logcat debug messages and |adb logcat -b radio| output ?

And/or try to reproduce with the js libril.

Comment 17

[:gerard-majax]

(In reply to Sharaf from comment #15)
> I have one device with gecko commit d0849cfd3c632a0bb60df28567d48fc01dae387c
> with Gaia master.
> Unfortunately in that device also issue is reproduced. :-(

Would be useful if you could check whether this can be reproduced on v1.3, v1.4 also, with the respective gecko/gaia.

Comment 18

[Sharaf]

Hi,

After doing some analysis, its clear that this issue is related to commercial RIL. After SIM unlock fails the RIL sends a "iccinfochanged" event immediately. Because of this the sim_lock resets the SIM PIN dialog.

with MozRIL it work as expected.

Comment 19

[:gerard-majax]

Someone from RIL component should have a look at this then.