998961 - Silence unused typedef warnings in gfx/harfbuzz/

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Biru [:poiru]]

Silence ~100 warnings such as:

 3:05.64 In file included from /mozilla-central/obj-d/gfx/harfbuzz/src/Unified_cpp_gfx_harfbuzz_src0.cpp:2:0:
 3:05.64 /mozilla-central/gfx/harfbuzz/src/hb-buffer.cc: In member function ‘bool hb_buffer_t::enlarge(unsigned int)’:
 3:05.64 Warning: -Wunused-local-typedefs in /mozilla-central/gfx/harfbuzz/src/hb-buffer.cc: typedef ‘_static_assert_on_line_100_failed’ locally defined but not used
 3:05.64 /mozilla-central/gfx/harfbuzz/src/hb-buffer.cc:100:15: warning: typedef ‘_static_assert_on_line_100_failed’ locally defined but not used [-Wunused-local-typedefs]
 3:05.64    ASSERT_STATIC (sizeof (info[0]) == sizeof (pos[0]));
 3:05.64                ^

Comment 1

[Biru [:poiru]]

Attachment: Silence unused typedef warnings in gfx/harfbuzz/

Comment 2

[Jonathan Kew [:jfkthame]]

I see this is a new warning in gcc 4.8, which is why we haven't been seeing it in standard mozilla-central build logs.

According to some comments I've found, it may be fixable via the __attribute__((unused)) annotation in the source. So I'd suggest reporting this upstream, and see if it can be fixed there.

Comment 3

[Biru [:poiru]]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> According to some comments I've found, it may be fixable via the
> __attribute__((unused)) annotation in the source. So I'd suggest reporting
> this upstream, and see if it can be fixed there.

Upstream bug report: https://bugs.freedesktop.org/show_bug.cgi?id=77732

Should this bug be closed?

Comment 4

[Jonathan Kew [:jfkthame]]

Let's wait and see what happens with the upstream report and patch.

Once it's fixed there, and we take our next harfbuzz update, we can resolve this bug.

Comment 5

[John Daggett (:jtd)]

Comment on attachment 8409679 [details] [diff] [review]
Silence unused typedef warnings in gfx/harfbuzz/

Canceling the review for now, will fix upstream.

Comment 6

[Daniel Holbert [:dholbert]]

Looks like this was indeed fixed upstream, according to
  https://bugs.freedesktop.org/show_bug.cgi?id=77732#c2

John[athan], any idea when our next harfbuzz update is coming?)

Comment 7

[Jonathan Kew [:jfkthame]]

I'd like to take one soon. Behdad did a release (0.9.30) a few days ago, so we should update to that, but would like to run some tests before we drop in the new code. Just a question of finding the time...

Comment 8

[Biru [:poiru]]

Fixed in bug 1036981.