999080 - Add-ons manager hidden tabs are always displayed

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Franck (Wip)]

Attachment: addons-manager.jpg

Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0
Fresh install, new profile, no add-on installed.

Reproducible with Firefox 29 beta9, on Windows XP only.
Not reproducible on Windows 7.

Steps to reproduce:
Open add-ons manager, either via the menu, Ctrl+Shift+A shortcut or the about:addons URL.

Actual results:
Tabs such as "Search", "Available Updates" or "Recent Updates" are visible.

Expected results:
Tabs such as "Search", "Available Updates" or "Recent Updates" should be hidden.

This seems to be a regression.

Comment 1

[:Gijs (he/him)]

Are there any errors in the browser console?

Comment 2

[Franck (Wip)]

I did the following :
  1. set the current selection to "Appearance"
  2. close the add-ons manager tab
  3. open the browser console (CTRL+SHIFT+J)
  4. clear the browser console
  5. open back the download manager (CTRL+SHIFT+A)
  6. no error whatsoever

The console only contains this line (all filters enabled except CSS Log) :
  file:///C:/Program%20Files/Mozilla%20Firefox/browser/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/icon.png

Comment 3

[:Gijs (he/him)]

(In reply to wip.the.gruik from comment #2)
> I did the following :
>   1. set the current selection to "Appearance"
>   2. close the add-ons manager tab
>   3. open the browser console (CTRL+SHIFT+J)
>   4. clear the browser console
>   5. open back the download manager (CTRL+SHIFT+A)
>   6. no error whatsoever
> 
> The console only contains this line (all filters enabled except CSS Log) :
>  
> file:///C:/Program%20Files/Mozilla%20Firefox/browser/extensions/%7B972ce4c6-
> 7e08-4474-a285-3208198ce6fd%7D/icon.png

I can reproduce this, on beta9 as well as trunk. This is very odd. It WFM on Windows 8 and OS X as well, with the same beta. I'm about to head to sleep, but this seems very bad. It looks like it's because bug 980339 added %ifdefs, but that file actually isn't preprocessed so now there's just a bunch of CSS brokenness in the resulting file.

Comment 4

[:Gijs (he/him)]

Attachment: preprocess extensions.css,

This fixes things. I'm not sure if we're comfortable taking this on beta. If not, I think we should back out the offending patch.

Comment 5

[:Gijs (he/him)]

As noted on IRC:  I believe we should either try to get the patch there for 29 release, or back out the original patch, because IMO the current state isn't something we should ship; it's a highly visible regression for our XP users (of which there are probably not many on nightly/aurora/beta, but many more on release...)

Comment 6

[:Gijs (he/him)]

I'm told we're merging to release *now*. I think we should back bug 980339 out from release (in part because I'm not even sure WINDOWS_AERO is defined for toolkit/....//extensions.css, I assumed due diligence on the part of the patch author, and tested on XP (which worked - but might be broken on Win8 with this patch)). I won't be around to do it. Gavin/Justin/Lukas, if you agree, can one of you please do that? I won't be around until tomorrow, I'm afraid.

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8409851 [details] [diff] [review]
preprocess extensions.css,

r+ as this is just matching what aero does.

Comment 8

[Matthew N. [:MattN]]

(In reply to :Gijs Kruitbosch from comment #6)
> I'm told we're merging to release *now*. I think we should back bug 980339
> out from release (in part because I'm not even sure WINDOWS_AERO is defined
> for toolkit/....//extensions.css.

WINDOWS_AERO gets defined in toolkit/themes/windows/mozapps/extensions/extensions-aero.css which gets chosen from jar.mn for Vista and up.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

We're going to back out bug 980339 on beta for 29. We can take the forward fix for 30/31.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Backed out bug 980339 on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/02556a393ed8

Comment 11

[Tim Nguyen :ntim]

Sorry :/

Comment 12

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #11)
> Sorry :/

Don't worry. All of us make mistakes. Sometimes the mistakes don't get caught for a while. Fortunately, we found this one just in time (thanks, wip.the.gruik!).

Landed the patch on fx-team:
remote:   https://hg.mozilla.org/integration/fx-team/rev/c40d3b63ea6f

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c40d3b63ea6f

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/36f67ce46855

Comment 15

[Ada [:adalucinet]]

Reproduced with Nightly from 2014-04-21 with steps from comment 0.
Verified fixed with Firefox 29 RC (Build ID: 20140421221237), 30 beta 1 (Build ID: 20140428174145) and latest Aurora 31.0a2 (Build ID: 20140504004003) on Windows XP x32 and x64:

Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0