999090 - (Glow:ShareLimit) Adjust Share Limit To Prevent Issues With data At Launch

Status: VERIFIED FIXED

(Websites :: glow.mozilla.org, defect)

Description

[Ben (:bensternthal)]

Some notes from irc:

1) We want to remove the 500 share threshold for displaying data
2. We will ensure we have enough shares for USA to at least show the stacked bar at release
3) Continents with no data will read 0

Comment 1

[Ali Almossawi]

To clarify, I'll be making changes to address point (3) and adding a message to the Stats page's chart 3 when there isn't data for at least 10 countries.

Removing the 500 share threshold would be done by pmac.

Comment 2

[Ali Almossawi]

This PR addresses the requested changes: https://github.com/mozilla/mrburns/pull/99

Perhaps we ought to reset the db a second time later this week to confirm that the changes do in fact work as expected.

Comment 3

[Rebecca Billings [:rbillings]]

Please add QA verification steps or mark as [qa-]

Comment 4

[Ben (:bensternthal)]

Ali: 

Can you add to this bug what rebecca should look out for when we reset the DB.

For example. How many shares do we need so that we do not see the 'no data' note.

Rebecca - we can have pmac reset the db on thursday so we can do a test.

Comment 5

[Ali Almossawi]

Rebecca,

Below is the expected behavior once we reset the db:

Map:
1) The glows ought to start appearing right away.
2) Clicking on any of the choice views in the left-hand side menu ought to show a value for each continent. Continents that have no data yet ought to show 0%.

Stats:
1) The donut chart ought to work right away.
2) The stacked bar chart for the US ought to be populated. The dropdown ought to have at least 'USA' as an option.
3) The country comparison chart ought to show a message indicating that we don't have enough data yet and hence can't display the chart just yet. Once we have share data from at least 15 countries, you should see that chart enabled. Last time, it took about an hour for that to happen.


This change will need to be implemented before resetting the db: https://bugzilla.mozilla.org/show_bug.cgi?id=999729

We also have an implicit invariant that states that we will have share data from the US immediately after the site goes live. To achieve that, a few of us will likely have to click on various choices on the initial modal right after resetting the db.

Another thing to keep in mind is that there initially won't be a limit for how many share data points we need to have from a country in order to show it in the dropdown and on the country comparison chart. So we may see situations where the US is shown alongside, say, Isle of Man and Antarctica, which, admittedly, isn't all that meaningful. Once we start getting data from more and more countries, the expectation is that we'll start increasing that limit until it approaches the 500 data points threshold that we initially had.

Comment 6

[Rebecca Billings [:rbillings]]

DB was reset. Verified Map & Stats. Please resolved fixed unless there is another change or verification needed.