999203 - Tabs always restore from last time, even if preference is disabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Comment 1

[Flaviu Cos]

Environment: 
Device: Samsung Galaxy Note Tab (Android 4.1.2);
Build: Nightly 31.0a1 (2014-04-23);

Steps to reproduce:
1. Open a few tabs;
2. Restart firefox.

Expected result:
After restart only one about:home tab is opened.

Actual result:
All the opened tabs from step 1 are restored.

Comment 2

[Flaviu Cos]

Last good revision: e71ed4135461
First bad revision: 7fe3ee0cf8be
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e71ed4135461&tochange=7fe3ee0cf8be

Comment 3

[Aaron Train [:aaronmt]]

Probably

5a1b6dfdff18	Brian Nicholson — Bug 995741 - Restore tabs after crash. r=mfinkle

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Add a pref to record crashes

I thought that PREFS_WAS_STOPPED was set only in CrashReporter to remember that we crashed, but it looks like it's used more generally to record whether we died in the background (http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#2058).

Since PREFS_WAS_STOPPED won't help us, we need a separate pref for recording crashes.

Comment 6

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/542f5fb83cec

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/542f5fb83cec

Comment 8

[Cristina Madaras, QA [:CristinaM]]

I still can reproduce this on Nightly (2014-04-25) using Nexus 5 (Android 4.4.2) and Galaxy Nexus (Android 4.2.1)

Comment 9

[Aaron Train [:aaronmt]]

(In reply to cristina.madaras from comment #8)
> I still can reproduce this on Nightly (2014-04-25) using Nexus 5 (Android
> 4.4.2) and Galaxy Nexus (Android 4.2.1)

This didn't make today (04/25's) build. Try tomorrow's build.

Comment 10

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on:
Build: Nightly (2014-04-27)
Devices: Nexus 5 (Android 4.4.2) and Galaxy Nexus (Android 4.2.1)