Closed
Bug 999203
Opened 10 years ago
Closed 10 years ago
Tabs always restore from last time, even if preference is disabled
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox31 verified, fennec31+)
VERIFIED
FIXED
Firefox 31
People
(Reporter: mcomella, Assigned: bnicholson)
References
Details
(Keywords: regression)
Attachments
(1 file)
3.84 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•10 years ago
|
||
Environment: Device: Samsung Galaxy Note Tab (Android 4.1.2); Build: Nightly 31.0a1 (2014-04-23); Steps to reproduce: 1. Open a few tabs; 2. Restart firefox. Expected result: After restart only one about:home tab is opened. Actual result: All the opened tabs from step 1 are restored.
status-firefox31:
--- → affected
Comment 2•10 years ago
|
||
Last good revision: e71ed4135461 First bad revision: 7fe3ee0cf8be Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e71ed4135461&tochange=7fe3ee0cf8be
Keywords: regression
Comment 3•10 years ago
|
||
Probably 5a1b6dfdff18 Brian Nicholson — Bug 995741 - Restore tabs after crash. r=mfinkle
Blocks: 995741
Updated•10 years ago
|
tracking-fennec: --- → ?
Updated•10 years ago
|
Assignee: nobody → bnicholson
tracking-fennec: ? → 31+
Assignee | ||
Comment 5•10 years ago
|
||
I thought that PREFS_WAS_STOPPED was set only in CrashReporter to remember that we crashed, but it looks like it's used more generally to record whether we died in the background (http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#2058). Since PREFS_WAS_STOPPED won't help us, we need a separate pref for recording crashes.
Attachment #8412022 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #8412022 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/542f5fb83cec
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/542f5fb83cec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Comment 8•10 years ago
|
||
I still can reproduce this on Nightly (2014-04-25) using Nexus 5 (Android 4.4.2) and Galaxy Nexus (Android 4.2.1)
Comment 9•10 years ago
|
||
(In reply to cristina.madaras from comment #8) > I still can reproduce this on Nightly (2014-04-25) using Nexus 5 (Android > 4.4.2) and Galaxy Nexus (Android 4.2.1) This didn't make today (04/25's) build. Try tomorrow's build.
Comment 10•10 years ago
|
||
Verified as fixed on: Build: Nightly (2014-04-27) Devices: Nexus 5 (Android 4.4.2) and Galaxy Nexus (Android 4.2.1)
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•