999208 - [Flame] [E.me] Icons are fuzzy and pixelated on a 4" screen

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Tony Chung [:tchung]]

Attachment: screenshot of pixelated icons

When searching for e.me results, the icons returned are pixelated and fuzzy.  This is on a 4" screen.  

It seems to appear correctly on a 3.5" screen  (Open C)

Screenshot attached on 4" screen

Repro:
1) install 2.0 on Flame nightly.  

Gaia      eb97461e75cd44d20967bc410b5653dff031ef5a
Gecko     https://hg.mozilla.org/mozilla-central/rev/5010b38abf18
BuildID   20140421040204
Version   31.0a1
ro.build.version.incremental=68

2) scroll to e.me screen, do a search  
3) Verify loaded icons are pixelated and blurry

Expected:
- icons are optimized for 4" screen, and should look clear and crisp.

Comment 1

[Jason Smith [:jsmith]]

Adding qawanted to check to see if we can reproduce on the latest trunk build & 1.4 Flame.

Comment 2

[jcastro]

This is occurring on a Flame running 1.4. Most noticeable on the Flickr and Yelp icons. 

1.4 Environmental Variables:
Device: Flame 1.4 MOZ
BuildID: 20140507000202
Gaia: bac831d2ebc567f0939e41fbd8a4c15ef183b954
Gecko: 8040ccd0d4b1
Version: 30.0
Firmware Version: V10E
______________________________________________________________________________________________

Reproduces on a flame running 2.0/central/master/trunk. Check Yelp, Ticket Web and Flickr.

2.0 Environmental Variables:
Device: Flame 2.0 MOZ
BuildID: 20140507040203
Gaia: 870a5c518742665d36b17e7e88c2ab07d440b94c
Gecko: 417acde736e7
Version: 32.0a1
Firmware Version: V10E

Comment 3

[Jason Smith [:jsmith]]

Can we also check if this happens on a 1.3 Flame build?

Comment 4

[jcastro]

This issue occurs on a Flame with 1.3. Tested on a freshly based Flame device, using V10E. Issue is much more prevalent.

1.3 Environmental Variables:
Device: Flame 1.3 MOZ
BuildID: 20140414142245
Gaia: 70d6403322ebbbc56b41ef4231e99597a92e3330
Gecko:
Version: 28.0
Firmware Version: V10E

Comment 5

[Gregor Wagner [:gwagner]]

Ran, anything we can do here to improve the icons?

Comment 6

[Jason Smith [:jsmith]]

This might already be fixed. Flame was running under a 1.0 DPI setting when this bug was filed. Recently, we fixed this to run under 1.5 DPI in Flame builds.

QA Wanted for a retest.

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

What Jason concluded makes sense to me.

Comment 8

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue still occurs as of the latest Central Nightly build.

2.0 Environmental Variables:
Device: Flame 2.0
BuildID: 20140520000201
Gaia: 17b102ee8d9a724b62285547cc5f1c5d30bfb01c
Gecko: 95be84248033
Version: 30.0
Firmware Version: v10F-3

Icons for many sites are still blurry in Everything.Me on the latest 2.0 build.

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Non-pixelated icons (Flame 1.5 dpi)

Just tried it on Flame with "GAIA_DEVICE_PIXELS_PER_PX=1.5 make reset-gaia" and icons look crisper.
Attached a screenshot.

Comment 10

[Candice Serran (:cserran)]

Needs to retested per jsmith's reco

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: Blurry Icons on the latest nightly build

Icons for many sites are still blurry on the latest Nightly Central build.  Attached is a screenshot showing some of these icons.  Of note: Yelp, Google Maps, Google Street View, and Google Weather are all very blurry and the rest are somewhat blurry.

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Build info for comment 11

2.0 Environmental Variables:
Device: Flame 2.0
BuildID: 20140527040202
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: cbe4f69c2e9c
Version: 32.0a1
Firmware Version: v10G-2

Comment 13

[Ran Ben Aharon [:ranbena] EverythingMe]

Could it be a problem with the Nightly build?
Notice that the (X) next to the searchbar is blurry as well.

Comment 14

[bhavana bajaj [:bajaj]]

Is this an issue with e.me deliverable(server side) or a device issue ?

Comment 15

[Ran Ben Aharon [:ranbena] EverythingMe]

E.me icons return from the server 88px by 88px.
The code that renders the final icon <canvas>, calculates it's size by "homescreen icon size" multiplied by window.devicePixelRatio.

Comment 16

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Non-pixelated icons (Peak 1.68 dpi)

Tried v1.4 on my Peak device and it all looks well. Attached

Comment 17

[Gregor Wagner [:gwagner]]

Can we close this bug now?

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: Verticle homescreen blurry Eme icons

Comment 19

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

On the latest nightly, this issue does not occur on the original homescreen.  It does occur when using E.me on the Vertical homescreen.  Screenshot above shows this issue.

Environmental Variables:
Device: Flame
BuildID: 20140609040203
Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
Gecko: 9305a8ec77fe
Version: 32.0a1

Comment 20

[Ran Ben Aharon [:ranbena] EverythingMe]

Collections in home2 are a WIP. I'll back to this once we're done.

Comment 21

[Ran Ben Aharon [:ranbena] EverythingMe]

A simple test I did:

Inspected search result icon. Looks similar to this
> <div class="icon bookmark editable" style="background-image: url("blob:d3a1d20b-0bfb-4280-9bac-
> 27733f9025f3");" data-test-icon="http://api.everything.me/partners/1.0/Icon/get?
> id=555&iconFormat=20&apiKey=79011a035b40ef3d7baeabc8f85b862f"></div>

The image displayed is a blob created by GridItemRenderer (in order to clip the icon).
The original image is available in "data-test-icon".

I set the original image as the background and the icon looks sharp.

Conclusions:
1. E.me server supplies high quality image sized 88x88 pixels.
2. Image manipulation done by GridItemRenderer might be causing icon quality deterioration.

This can be seen in web result icons in the search app as well as smart collections.

Kevin, who can look into this?

Comment 22

[James Lal [:lightsofapollo]]

Will investigate now...

Comment 23

[James Lal [:lightsofapollo]]

Attachment: 2014-06-24-09-39-20.png

On the latest nightly build for mozilla-central I can't reproduce this... I found another bug however which is the marketplace is returning 64x64 icons (for yelp in this instance) which may have been the error you saw. I will file another bug about this one and close this.

Comment 24

[James Lal [:lightsofapollo]]

Please re-open if this can be reproduced for e.me icons.

Comment 25

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I see what James sees.  Worksforme or fixed.

Gaia      9d2f7bd16a8dc0c74c97c5a40d2f0731f3dfff4b
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/f118b45daada
BuildID   20140624000201
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
Flame

Comment 26

[Ryan VanderMeulen [:RyanVM]]

No specific fix = WFM (matters for tracking purposes)