Closed
Bug 999364
Opened 10 years ago
Closed 10 years ago
[Media Recorder] Fix the cluster length for WebM.
Categories
(Core :: Audio/Video: Recording, defect)
Core
Audio/Video: Recording
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: bechen, Assigned: bechen)
References
Details
Attachments
(5 files, 2 obsolete files)
Fork from Bug 969290 comment 2. Jim points out the data size of a cluster is not correct. Should fix in EbmlComposer::FinishCluster(). (Now we only compute the first block's size) reference: http://matroska.org/technical/specs/index.html search "Data size"
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → bechen
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8410899 [details]
element lengths in test2.webm
Hi Jim:
After apply my patch, I use the script you provide to generate the result.
Would you please give some feedback?
Attachment #8410899 -
Flags: feedback?(tramspap)
As far as I can tell, the element lengths are fixed, at least for this file. I took a closer look at the file with another script (output attached) to see if I could spot any other obvious problems, and I think I have. The duration given in the segment information is zero, as are all the timecodes of the blocks in the audio stream.
dependent on https://raw.githubusercontent.com/ccd0/containerchan/master/matroska.php https://raw.githubusercontent.com/ccd0/containerchan/master/matroska-elements.txt
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Jim Black from comment #5) > Created attachment 8410957 [details] > more detailed look at test2.webm > > As far as I can tell, the element lengths are fixed, at least for this file. > > I took a closer look at the file with another script (output attached) to > see if I could spot any other obvious problems, and I think I have. The > duration given in the segment information is zero, as are all the timecodes > of the blocks in the audio stream. Yeah, we don't output the timestamp for vorbis audio in VorbisTrackEncoder.c. It's not difficult to get the timestamp and duration for decoder by counting the audio samples
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8410896 -
Attachment is obsolete: true
Attachment #8411544 -
Flags: review?(giles)
Updated•10 years ago
|
Attachment #8411544 -
Flags: review?(giles) → review+
Assignee | ||
Comment 9•10 years ago
|
||
r=rillian try server: https://tbpl.mozilla.org/?tree=Try&rev=0e92bd257623
Attachment #8411544 -
Attachment is obsolete: true
Attachment #8414951 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cb07945825c
Keywords: checkin-needed
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8cb07945825c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Updated•10 years ago
|
Attachment #8410899 -
Flags: feedback?(tramspap)
You need to log in
before you can comment on or make changes to this bug.
Description
•