Closed Bug 999364 Opened 6 years ago Closed 6 years ago

[Media Recorder] Fix the cluster length for WebM.

Categories

(Core :: Audio/Video: Recording, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: bechen, Assigned: bechen)

References

Details

Attachments

(5 files, 2 obsolete files)

Fork from Bug 969290 comment 2.
Jim points out the data size of a cluster is not correct.
Should fix in EbmlComposer::FinishCluster(). (Now we only compute the first block's size)

reference:
http://matroska.org/technical/specs/index.html
search "Data size"
Blocks: 951040
Attached patch bug-999364.patch (obsolete) — Splinter Review
Assignee: nobody → bechen
Status: NEW → ASSIGNED
Attached video test2.webm
Comment on attachment 8410899 [details]
element lengths in test2.webm

Hi Jim:
After apply my patch, I use the script you provide to generate the result.
Would you please give some feedback?
Attachment #8410899 - Flags: feedback?(tramspap)
As far as I can tell, the element lengths are fixed, at least for this file.

I took a closer look at the file with another script (output attached) to see if I could spot any other obvious problems, and I think I have.  The duration given in the segment information is zero, as are all the timecodes of the blocks in the audio stream.
(In reply to Jim Black from comment #5)
> Created attachment 8410957 [details]
> more detailed look at test2.webm
> 
> As far as I can tell, the element lengths are fixed, at least for this file.
> 
> I took a closer look at the file with another script (output attached) to
> see if I could spot any other obvious problems, and I think I have.  The
> duration given in the segment information is zero, as are all the timecodes
> of the blocks in the audio stream.

Yeah, we don't output the timestamp for vorbis audio in VorbisTrackEncoder.c.
It's not difficult to get the timestamp and duration for decoder by counting the audio samples
Attached patch bug-999364.patch (obsolete) — Splinter Review
Attachment #8410896 - Attachment is obsolete: true
Attachment #8411544 - Flags: review?(giles)
Attachment #8411544 - Flags: review?(giles) → review+
Attached patch bug-999364.patchSplinter Review
r=rillian
try server: https://tbpl.mozilla.org/?tree=Try&rev=0e92bd257623
Attachment #8411544 - Attachment is obsolete: true
Attachment #8414951 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8cb07945825c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Attachment #8410899 - Flags: feedback?(tramspap)
You need to log in before you can comment on or make changes to this bug.