Closed Bug 999396 Opened 10 years ago Closed 10 years ago

[Camera] face detection pref setting

Categories

(Firefox OS Graveyard :: General, defect, P3)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)

People

(Reporter: shinuk153, Assigned: shinuk153)

References

(
URL
)

Details

(Keywords: common-issue+, Whiteboard: camera face detection API preference setting)

Attachments

(1 file, 2 obsolete files)

camera face-detection preference patch
741 bytes, patch
mikeh
: review+
hkoka
: superreview+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.154 Safari/537.36

Steps to reproduce:

The changeset of Bug 965420 integrated to the master source baseline.
But because of Camera pref setting, camera app couldn't use face detection API without preference change.
Please consider "camera.control.face_detection.enabled" to change from false to true as a default preference.
URL: https://hg.mozilla.org/mozilla-centra...
Depends on: 965420
Flags: needinfo?(mhabicher)
Keywords: common-issue+
OS: All → Gonk (Firefox OS)
Priority: -- → P3
Hardware: All → ARM
Whiteboard: camera face detection API preference setting
I think we can do that.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(mhabicher)
Attached patch camera preference patch proposal (obsolete) — — Splinter Review 
Please find attached patch for camera preference change.
Flags: needinfo?(mhabicher)
(In reply to shinuk from comment #2)
> 
> Please find attached patch for camera preference change.

This is fine. Please make sure that any changes to the Camera app dependent on face-detection support will degrade gracefully if this pref is flipped back to 'false'.

If you would like this patch to land, please make sure the diff has 8 lines of context (-U8 in git and hg), and has a properly-formatted header, e.g.

From: shinuk <shinuk153@gmail.com>

Bug 999396 - flip camera face-detection pref on

diff --git ...

...and r? me.
Flags: needinfo?(mhabicher)
Thank you for your comment.
Please find an attached patch for camera face-detection pref.
Attachment #8418523 - Attachment is obsolete: true
Flags: needinfo?(mhabicher)

        Attachment #8419083 -
        Attachment is obsolete: true
Flags: needinfo?(mhabicher)

    
    

    
  
Comment on attachment 8419093 [details] [diff] [review]
camera face-detection preference patch

Review of attachment 8419093 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. Hema, does this line up with the overall project?

        Attachment #8419093 -
        Flags: superreview?(hkoka)

        Attachment #8419093 -
        Flags: review+

    
  

        Attachment #8419093 -
        Flags: superreview?(hkoka) → superreview+

    
  
Target Milestone: --- → 2.0 S1 (9may)

    
  
Assignee: nobody → shinuk153

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: