999396 - [Camera] face detection pref setting

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P3)

Description

[shinuk]

User Agent: Mozilla/5.0 (Windows NT 6.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.154 Safari/537.36

Steps to reproduce:

The changeset of Bug 965420 integrated to the master source baseline.
But because of Camera pref setting, camera app couldn't use face detection API without preference change.
Please consider "camera.control.face_detection.enabled" to change from false to true as a default preference.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

I think we can do that.

Comment 2

[shinuk]

Attachment: camera preference patch proposal

Please find attached patch for camera preference change.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to shinuk from comment #2)
> 
> Please find attached patch for camera preference change.

This is fine. Please make sure that any changes to the Camera app dependent on face-detection support will degrade gracefully if this pref is flipped back to 'false'.

If you would like this patch to land, please make sure the diff has 8 lines of context (-U8 in git and hg), and has a properly-formatted header, e.g.

From: shinuk <[e-mail]>

Bug 999396 - flip camera face-detection pref on

diff --git ...

...and r? me.

Comment 4

[shinuk]

Attachment: camera face-detection preference patch

Thank you for your comment.
Please find an attached patch for camera face-detection pref.

Comment 5

[shinuk]

Attachment: camera face-detection preference patch

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8419093 [details] [diff] [review]
camera face-detection preference patch

Review of attachment 8419093 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. Hema, does this line up with the overall project?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/68576248776c

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/68576248776c