999415 - corrupted video clips does not enumerates in video app

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Video, defect, P1)

Description

[Pooja]

Attachment: Corrupted video clips to test

Steps to reproduce:
1. Save corrupted/unsupported clips in sdcard
2. Open video app

Actual behavior:
None of the clips are enumerated.

Expected behavior:
All kind of clips (corrupted or normal) should atleast enumerate with black thumbnail and show error in the UI while user tries to play.

Have found that getMetadata() fails for corrupted/error clips at [1] and so here we set isVideo = false, which further avoid adding files as thumbnail at [2]

Is it possible to show black thumbnails with video name so user is aware that file is actually copied but corrupted / not supported?

[1] https://www.codeaurora.org/cgit/quic/lf/b2g/mozilla/gaia/tree/apps/video/js/metadata.js?h=mozilla/v1.4#n182

[2] https://www.codeaurora.org/cgit/quic/lf/b2g/mozilla/gaia/tree/apps/video/js/metadata.js?h=mozilla/v1.4#n144

Comment 1

[Jason Smith [:jsmith]]

This is expected behavior - we don't show corrupted video clips in the video app. If we did, then that would be poor UX, as we would be showing videos that users can't play.

Comment 2

[vasanth]

(In reply to Jason Smith [:jsmith] from comment #1)
> This is expected behavior - we don't show corrupted video clips in the video
> app.

If user has downloaded a corrupted video, he might think download was unsuccessful.
How do we notify error to the user in this case?

Comment 3

[Jason Smith [:jsmith]]

I think that case is already handled to my understanding in the download manager workflow. I think we do throw an error.

Comment 4

[vasanth]

(In reply to Jason Smith [:jsmith] from comment #3)
> I think that case is already handled to my understanding in the download
> manager workflow. I think we do throw an error.

I guess download manager can throw error when download fails. Not sure how it can find video is corrupted? What if actual file is corrupted but download is successful?

Comment 5

[Jason Smith [:jsmith]]

(In reply to vasanth from comment #4)
> (In reply to Jason Smith [:jsmith] from comment #3)
> > I think that case is already handled to my understanding in the download
> > manager workflow. I think we do throw an error.
> 
> I guess download manager can throw error when download fails. Not sure how
> it can find video is corrupted? What if actual file is corrupted but
> download is successful?

To my understanding, the video app will open, but the video will fail to play & an error will fire indicating that the video could not be played.

Feel free to test this yourself to see what I mean. If this doesn't work, then that's a bug that we need to fix.

Comment 6

[vasanth]

(In reply to Jason Smith [:jsmith] from comment #5)
> Feel free to test this yourself to see what I mean. If this doesn't work,
> then that's a bug that we need to fix.

Tried that and it shows error properly. Thanks!