Closed Bug 999464 Opened 6 years ago Closed 6 years ago

[Camera][Gecko] Switch CameraPoint to DOMPoint

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S1 (9may)

People

(Reporter: mikeh, Assigned: aosmond)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 2 obsolete files)

Bug 917755 added DOMPoints, which are the same as CameraPoints, added for face-tracking in bug 965420. We should replace the latter with the former.
Assignee: nobody → aosmond
Attached patch bug999464.patch, v1 (obsolete) — Splinter Review
Switched to using DOMPoint, passes the test_camera_hardware_face_detection.html test cases.
Attachment #8414691 - Flags: review?(mhabicher)
Status: NEW → ASSIGNED
Attachment #8414691 - Attachment description: bug999464.patch → bug999464.patch, v1
Comment on attachment 8414691 [details] [diff] [review]
bug999464.patch, v1

Review of attachment 8414691 [details] [diff] [review]:
-----------------------------------------------------------------

r+ from me, with the nit below addressed.

bz, do you have time to review a relatively simple DOM-facing change?

::: dom/webidl/CameraControl.webidl
@@ +396,5 @@
>  
>    readonly attribute DOMRect bounds;
>  
>    readonly attribute boolean hasLeftEye;
> +  readonly attribute DOMPoint? leftEye;

Can you add some documentation to this interface describing the limits of the feature DOMPoints, similar to what CameraPoint used to have? (i.e. the -1000 to 1000 limits.)
Attachment #8414691 - Flags: review?(mhabicher)
Attachment #8414691 - Flags: review?(bzbarsky)
Attachment #8414691 - Flags: review+
Attached patch bug999464.patch, v2 [r=mikeh] (obsolete) — Splinter Review
Addressed nits by expanding documentation header for interface.
Attachment #8414691 - Attachment is obsolete: true
Attachment #8414691 - Flags: review?(bzbarsky)
Attachment #8414712 - Flags: review?(bzbarsky)
Comment on attachment 8414712 [details] [diff] [review]
bug999464.patch, v2 [r=mikeh]

r=me
Attachment #8414712 - Flags: review?(bzbarsky) → review+
Update patch tagline for completed reviews
Attachment #8414712 - Attachment is obsolete: true
Attachment #8416169 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d97263d58ac5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.