999464 - [Camera][Gecko] Switch CameraPoint to DOMPoint

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Bug 917755 added DOMPoints, which are the same as CameraPoints, added for face-tracking in bug 965420. We should replace the latter with the former.

Comment 1

[Andrew Osmond [PLEASE USE MOZILLA ACCT]]

Attachment: bug999464.patch, v1

Switched to using DOMPoint, passes the test_camera_hardware_face_detection.html test cases.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8414691 [details] [diff] [review]
bug999464.patch, v1

Review of attachment 8414691 [details] [diff] [review]:
-----------------------------------------------------------------

r+ from me, with the nit below addressed.

bz, do you have time to review a relatively simple DOM-facing change?

::: dom/webidl/CameraControl.webidl
@@ +396,5 @@
>  
>    readonly attribute DOMRect bounds;
>  
>    readonly attribute boolean hasLeftEye;
> +  readonly attribute DOMPoint? leftEye;

Can you add some documentation to this interface describing the limits of the feature DOMPoints, similar to what CameraPoint used to have? (i.e. the -1000 to 1000 limits.)

Comment 3

[Andrew Osmond [PLEASE USE MOZILLA ACCT]]

Attachment: bug999464.patch, v2 [r=mikeh]

Addressed nits by expanding documentation header for interface.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8414712 [details] [diff] [review]
bug999464.patch, v2 [r=mikeh]

r=me

Comment 5

[Andrew Osmond [PLEASE USE MOZILLA ACCT]]

try-server push: https://tbpl.mozilla.org/?tree=Try&rev=13ab6e387cf1

Comment 6

[Andrew Osmond [PLEASE USE MOZILLA ACCT]]

Attachment: bug999464.patch, v2 [r=bz,mikeh]

Update patch tagline for completed reviews

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d97263d58ac5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d97263d58ac5