999518 - browser/base/content/test/general/browser_aboutAccounts.js attempts to connect to api.accounts.firefox.com

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Nathan Froyd [:froydnj]]

With the patches from bug 995417:

09:47:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | Check account log in
09:47:44     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | Checking number of results received matches the number of tests that should have run
09:47:44     INFO -  1398185264767	Sync.BrowserIDManager	ERROR	Non-authentication error in _fetchTokenForUser: A different user signed in
09:47:44     INFO -  1398185264770	Sync.BrowserIDManager	ERROR	Background fetch for key bundle failed: Error: A different user signed in
09:47:44     INFO -  1398185264770	Sync.BrowserIDManager	ERROR	Could not authenticate: Error: A different user signed in
09:47:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | Console message: 1398185264767	Sync.BrowserIDManager	ERROR	Non-authentication error in _fetchTokenForUser: A different user signed in
09:47:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | Console message: 1398185264770	Sync.BrowserIDManager	ERROR	Background fetch for key bundle failed: Error: A different user signed in
09:47:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | Console message: 1398185264770	Sync.BrowserIDManager	ERROR	Could not authenticate: Error: A different user signed in
09:47:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | Test action=signin - no user logged in
09:47:44     INFO -  1398185264896	Sync.BrowserIDManager	ERROR	Could not authenticate: no user is logged in
09:47:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | Console message: 1398185264896	Sync.BrowserIDManager	ERROR	Could not authenticate: no user is logged in
09:47:44     INFO -  BAD CONNECT: connecting to api.accounts.firefox.com 0
09:47:47     INFO -  TEST-INFO | Main app process: killed by SIGHUP
09:47:47  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_aboutAccounts.js | application terminated with exit code 1

Our tests should not be connecting to external resources.

Comment 1

[Nathan Froyd [:froydnj]]

Mark, are you able to look at this bug and/or redirect it to someone who can?  This is one of the last bugs blocking bug 995417 and it'd be good to not disable our way to victory here.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-999518-don-t-hit-the-production-FxA-server-durin.patch

We don't rely on the production FxA server, it's just that the code tries to hit it anyway :)  The easiest solution and one that should prevent it coming up in the future is to override the pref pointing at the server.

The test passes locally for me with this patch and best I can tell, that server is never hit.  A try is at https://tbpl.mozilla.org/?tree=Try&rev=377b8de8416e

Natahan if you are able to review this, please steal of from Ted - I've only nominated him as I'm too lazy to look and see who else qualifies :)

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8419907 [details] [diff] [review]
0001-Bug-999518-don-t-hit-the-production-FxA-server-durin.patch

Review of attachment 8419907 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me with external network access disabled locally.  Maybe this fixes bug 958026, too?

Comment 4

[Mark Hammond [:markh] [:mhammond]]

(In reply to Nathan Froyd (:froydnj) from comment #3)

> Works for me with external network access disabled locally.  Maybe this
> fixes bug 958026, too?

That would certainly be a bonus :)

https://hg.mozilla.org/integration/fx-team/rev/fc69e8ac0db2

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/fc69e8ac0db2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/34458ec41195
https://hg.mozilla.org/releases/mozilla-beta/rev/2c4e64ce090e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/2c4e64ce090e