99955 - quicksearch does not have updated keyword, resolution, etc list for JS

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

When mozilla.org bug 89620 was fixed (removing the 'flash' keyword off the b.m.o
install), the "quick search" did not know the keyword was gone.  Hence, if you
currently search for any phrase involving flash, you will get an invalid keyword
error.

The javascript used for the quicksearch should be tied into the keyword list. 
We would either want to add it to localconfig.js or have a separate file for it.

Comment 1

[Andreas Franke (gone)]

The short-term fix for this problem would be to update the localconfig.js file
on b.m.o (removing the "flash" keyword entry there). 
Attachment 46089 [details] [diff] in bug 61561 is a patch that brings the keyword list a bit more
up-to-date, but doesn't fix that "flash" problem yet. It would be easy to create
an updated patch that takes care of the "flash" problem, too, but I can't see
why I should do that since nobody cares to apply it to b.m.o anyway.

The long-term fix for this problem is the patch provided in bug 72837 to
generate a JS file with the keyword list automatically. I'm marking this bug
dependent on that one for now.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

This looks similar to bug 69621.

Is it the same, or dependent?  Will fixing that automagically fix this too?

Comment 3

[Matthew Tuck [:CodeMachine]]

No this is unrelated.  This will also be a problem for resolutions once
customised resolutions (bug #94534) lands.

Comment 4

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 5

[Matthew Tuck [:CodeMachine]]

This is basically being done as a part of bug #70907, so replacing the
dependency on bug #72837 with it.

Comment 6

[Dave Miller [:justdave]]

All 2.18 bugs that haven't been touched in over 60 days and aren't flagged as
blockers are getting pushed out to 2.20

Comment 7

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 8

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: changeset: :8571114112b2

This patch doesn't break robocop/mochitest

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 644808 [details] [diff] [review]
changeset:   :8571114112b2

Wow, bzexport fail.