Closed Bug 999553 Opened 9 years ago Closed 9 years ago

Reenable most disabled unit tests on TBPL

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TestAgent
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

Details

Attachments

(2 files, 2 obsolete files)

github PR, render_test is enabled
46 bytes, text/x-github-pull-request
Details | Review
github PR, render_test is disabled
46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review 
Most unit tests run successfully on TBPL now. We should reenable them.
Attached file github PR with render_test (obsolete) — 
Try is https://tbpl.mozilla.org/?tree=Try&rev=5715d2ef0f88

The try when enabling the latest test was failing, it's https://tbpl.mozilla.org/?tree=Try&rev=f5b33710f1ed
Assignee: nobody → felash
Attachment #8410400 - Flags: review?(jgriffin)
Retriggering 6 times to hunt for intermittents.
Comment on attachment 8410400 [details] [review]
github PR with render_test

Thanks.  The retriggers were all green!
Attachment #8410400 - Flags: review?(jgriffin) → review+
That's great, hope it sticks!

Thanks Jonathan!

master: 22c2e53548dbc69c220c4eb943a99af9174b681a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Re-added render_test.js in the list of disabled tests.

Carrying r+ from the previous patch
Attachment #8410400 - Attachment is obsolete: true
Attachment #8411102 - Flags: review+
Do we know why the try push was green, but the actual push not?
Flags: needinfo?(felash)
There were some changes to that test yesterday, so that's the most likely reason, IMO.
oh right, and actually, these changes were reverted too.

So maybe we can try to remerge the initial pull request?
Flags: needinfo?(felash)
Attachment #8410400 - Attachment description: github PR → github PR with render_test
Attachment #8410400 - Attachment is obsolete: false
Attachment #8411102 - Attachment description: new Github PR → new Github PR, render_test.js stays disabled
I'll do a new rebased try tomorrow when git.mozilla.org will be up again.
Flags: needinfo?(felash)
try is https://tbpl.mozilla.org/?tree=Try&rev=f70463a5a962
Attachment #8410400 - Attachment is obsolete: true
Attachment #8411102 - Attachment is obsolete: true
Flags: needinfo?(felash)
Jonathan, both try are green, should I reland the patch which enable render_test.js too (I mean, the same one than before) ? Probably the failure were due to the changes that happened to render_test.js as you said, and which were backed out anyway.
Flags: needinfo?(felash) → needinfo?(jgriffin)
Yes, please re-land the original patch.
Flags: needinfo?(jgriffin)
master: 0d0746788fad5cb60937a8cc668b13fc6eadb105
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Attachment #8411833 - Attachment is obsolete: true
How could that happen? Why don't I see these failures in the Gaia try?

NI me to push the other commit then, we'll keep render_test disabled for now.
Flags: needinfo?(felash)
Attachment #8411833 - Attachment is obsolete: false
Flags: needinfo?(felash)
Comment on attachment 8411833 [details] [review]
github PR, render_test is disabled

carrying r=jgriffin
Attachment #8411833 - Flags: review+
master: 4a9beccde787ef22b03700cb536488172a0057f6

crossing fingers
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.