999565 - [tarako] add ability for reviewers to override Tarako-ready apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[David Durst [:ddurst]]

Reviewers need to be able to find all apps that have been designated as "Tarako-ready" by their submitter; they also need to be able to override (e.g. uncheck) that if review verifies the opposite.

Comment 1

[Rob Hudson [:robhudson]]

Proposal A: Add a tag search to reviewer tools. Reviewers can search for pending apps tagged "tarako".

Proposal B: If the reviewer finds the app lacking they can simply remove the tag. To save them a step we can add a checkbox to remove the tarako tag. If the checkbox comes back as checked we remove the tag upon submit.

Question: Do we want to provide the ability to add the tarako tag for reviewers? Perhaps they think an app might work on tarako while reviewing, check it, and find that it does but it doesn't have the tag?

Comment 2

[Andrew Williamson [:eviljeff]]

This kinda depends on bug 999562 and the outcome of Chuck's idea in bug 999555#c1 imo.

Comment 3

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #1)
> Proposal B: If the reviewer finds the app lacking they can simply remove the
> tag. To save them a step we can add a checkbox to remove the tarako tag. If
> the checkbox comes back as checked we remove the tag upon submit.

what kind of review action would this be linked to?  A comment?  An info request?  Or is this going to be directly shown in the search results?  

(Also I'd prefer it be a filled checkbox that was cleared - i.e. 'Tarako compatible app [x]' rather than a double negative). 
 
> Question: Do we want to provide the ability to add the tarako tag for
> reviewers? Perhaps they think an app might work on tarako while reviewing,
> check it, and find that it does but it doesn't have the tag?

I don't think that kind of additional test is going to be part of the review process, and none of our community reviewers currently have a Tarako device to test on.

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/eee0328