999572 - Fix settingsService usage in NetworkGeolocationProvider.js

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Comment 1

[Gregor Wagner [:gwagner]]

We are getting
E/GeckoConsole( 1463): [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISettingsServiceCallback.handle]" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsService.js" line: 121}]
E/GeckoConsole( 1463): [JavaScript Error: "NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED: JavaScript component does not have a method named: "handle"'JavaScript component does not have a method named: "handle"' when calling method: [nsISettingsServiceCallback::handle]" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsService.js" line: 121}]
E/GeckoConsole( 1463): [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISettingsServiceCallback.handle]" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsService.js" line: 121}]

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: 999572.diff

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8410646 [details] [diff] [review]
patch

Review of attachment 8410646 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/settings/SettingsService.js
@@ +42,5 @@
> +    dump("CaLLHandle with: " + aName + ", " + aValue + "\n");
> +    try {
> +      aCallback ? aCallback.handle(aName, aValue) : null;
> +    } catch (e) {
> +      throw e;

This will just rethrow the exception... I think you want to just ignore it?

::: dom/system/NetworkGeolocationProvider.js
@@ +103,5 @@
>        return;
>  
>      this.started = true;
> +    let settingsCallback = {
> +      handle: function(name, result) {

You probably want a handleError too.

@@ +111,5 @@
>  
>      try {
>        Services.obs.addObserver(this, SETTING_CHANGED_TOPIC, false);
>        let settings = Cc["@mozilla.org/settingsService;1"].getService(Ci.nsISettingsService);
> +      settings.createLock().get(SETTING_DEBUG_ENABLED, settingsCallback);

I probably would have just added a 'handle' and 'handleError' function to this object rather than make a new one, but it doesn't really change anything.

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: gaia

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/190a19291d8c

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/190a19291d8c

Comment 8

[Gregor Wagner [:gwagner]]

We need this to fix bug 1012214

Comment 9

[Gregor Wagner [:gwagner]]

Attachment: patch14

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/f69c5156998f

Comment 11

[Doug Turner (:dougt)]

we also needed this rebase: ... https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/b7a0806482f1