Closed
Bug 999572
Opened 10 years ago
Closed 10 years ago
Fix settingsService usage in NetworkGeolocationProvider.js
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
People
(Reporter: gwagner, Assigned: gwagner)
References
Details
(Whiteboard: [systemsfe][qa-])
Attachments
(3 files, 1 obsolete file)
6.76 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
46 bytes,
text/x-github-pull-request
|
bent.mozilla
:
review+
|
Details | Review |
5.00 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
We are getting E/GeckoConsole( 1463): [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISettingsServiceCallback.handle]" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsService.js" line: 121}] E/GeckoConsole( 1463): [JavaScript Error: "NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED: JavaScript component does not have a method named: "handle"'JavaScript component does not have a method named: "handle"' when calling method: [nsISettingsServiceCallback::handle]" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsService.js" line: 121}] E/GeckoConsole( 1463): [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISettingsServiceCallback.handle]" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsService.js" line: 121}]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → anygregor
Whiteboard: [systemsfe]
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 1.4 S6 (25apr)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8410598 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8410646 -
Flags: review?(bent.mozilla)
Comment on attachment 8410646 [details] [diff] [review] patch Review of attachment 8410646 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/settings/SettingsService.js @@ +42,5 @@ > + dump("CaLLHandle with: " + aName + ", " + aValue + "\n"); > + try { > + aCallback ? aCallback.handle(aName, aValue) : null; > + } catch (e) { > + throw e; This will just rethrow the exception... I think you want to just ignore it? ::: dom/system/NetworkGeolocationProvider.js @@ +103,5 @@ > return; > > this.started = true; > + let settingsCallback = { > + handle: function(name, result) { You probably want a handleError too. @@ +111,5 @@ > > try { > Services.obs.addObserver(this, SETTING_CHANGED_TOPIC, false); > let settings = Cc["@mozilla.org/settingsService;1"].getService(Ci.nsISettingsService); > + settings.createLock().get(SETTING_DEBUG_ENABLED, settingsCallback); I probably would have just added a 'handle' and 'handleError' function to this object rather than make a new one, but it doesn't really change anything.
Attachment #8410646 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8411187 -
Flags: review?(bent.mozilla)
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/190a19291d8c
Updated•10 years ago
|
Attachment #8411187 -
Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/190a19291d8c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•10 years ago
|
||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/f69c5156998f
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-firefox29:
--- → wontfix
status-firefox30:
--- → wontfix
status-firefox31:
--- → fixed
Comment 11•10 years ago
|
||
we also needed this rebase: ... https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/b7a0806482f1
You need to log in
before you can comment on or make changes to this bug.
Description
•