999668 - We don't linkify the alternative ssh remote syntax

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Git supports a protocol-less (non-URI) syntax for ssh remotes, and we don't linkify those.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-999668.patch

Linkify non-URI git remotes.

Comment 2

[:glob ✱]

Comment on attachment 8410511 [details] [diff] [review]
bug-999668.patch

Review of attachment 8410511 [details] [diff] [review]:
-----------------------------------------------------------------

it would be easier and quicker to make the |ssh://| part of the current git.m.o regex optional instead of creating a near-identical block.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-999668-v2.patch

I was uncomfortable making a change to an existing regex, so I wrote a test to make myself comfortable.
Note that the regex matches invalid combinations of : and /, such as  ssh://[e-mail]:bugzilla/bugzilla.git
or [e-mail]/bugzilla/bugzilla.git

Comment 4

[:glob ✱]

Comment on attachment 8411912 [details] [diff] [review]
bug-999668-v2.patch

Review of attachment 8411912 [details] [diff] [review]:
-----------------------------------------------------------------

the regex looks fine, but there's quite a few issues with your test script that i want to see addressed if it's to go into the tree.

::: extensions/BMO/t/bug_format_comment.t
@@ +1,1 @@
> +#!/usr/bin/perl -T

all files need a license header

@@ +24,5 @@
> +
> +# svn
> +r2424
> +
> +# bzr commit, TODO

now is the right time to do this TODO :)

@@ +39,5 @@
> +$bmo->bug_format_comment({ regexes => \@regexes });
> +
> +ok(@regexes > 0, "got some regexes to play with");
> +
> +for my $re (@regexes) {

s/for/foreach/

@@ +59,5 @@
> +    '<a href="http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github]  withuri -> withuri</a>',
> +    '<a href="http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github]  nouri -> nouri</a>',
> +);
> +
> +for my $link (@links) {

s/for/foreach/

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-999668-v3.patch

License, taint mode, bzr test case and stylistic change applied.

Comment 6

[:glob ✱]

Comment on attachment 8413577 [details] [diff] [review]
bug-999668-v3.patch

Review of attachment 8413577 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 7

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b2eb600..4543712  master -> master

And the following will work when this is pushed :-D

To [e-mail]:webtools/bmo/bugzilla.git
   b2eb600..4543712  master -> master