999699 - [B2G][Open_C][Camera]Countdown timer disappears

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

The countdown timer disappears after displaying the first number in the countdown. The countdown does not stop and the picture is still taken, only the timer numbers disappears.

Repro Steps:
1) Update a Open_C/Flame to BuildID: 20140422040203
2) Launch camera app
3) Select the options menu in the top right corner
4) Select Self-Timer and choose any time
5) Take a picture

Actual:
The countdown timer disappears

Expected:
The timer does not disappear until after it has finished counting down

2.0 Environmental Variables:
Device: Open_C 2.0 MOZ
BuildID: 20140422040203
Gaia: f0463704888881b8ed1619e8d4b0d851b0e0311b
Gecko: 1d0496e30feb
Version: 31.0a1
Firmware Version: V1.2-device.cfg

Repro frequency: 3/3, 100%
See attached: Video, logcat

Comment 1

[Andrew Stole [:astole]]

This issue does not occur on the latest Master build on Buri.

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on a 1.4 Open C build?

Comment 3

[J Zimbrick]

Unable to test this issue on 1.4 Open C currently.

Camera is blocked by Bug 1000567, displaying only a black screen with non-functional UI.

Can retest when Bug 1000567 is fixed.

1.4 Environmental Variables:
Device: Open C
BuildID: 20140429000201
Gaia: cf590ecb161e7b9fb4ccc672f950072acad62caa
Gecko: 32da83ceb532
Version: 30.0
Base Image: P821A10-ENG_20140410

Comment 4

[Jason Smith [:jsmith]]

Can this be reproduced on Flame on master? If so, can we check if this reproduces on Flame on 1.4?

Comment 6

[Sushil]

This is a regression caused by Bugzilla patch: https://bugzilla.mozilla.org/show_bug.cgi?id=993160.
When self-timer ticks and "2" & "1" fade-out, there are multiple containers in those particular frames which need "Intermediate surface" and they do not have any leaves. But HWC works only on leaf layers so we never reach the check at [1]. So it is better to let GPU handle a frame which needs intermediate surface. I checked by reverting this patch, the regression is fixed. I also verified that the original bug reported in Bugzilla # 993160 , does not exist even after reverting the patch, which means Camera preview is using HWC Composition on b2g v1.4 reference device, so we can now safely revert the patch. I will upload the revert of this patch.

[1]: http://mxr.mozilla.org/mozilla-central/source/widget/gonk/HwcComposer2D.cpp#331

Comment 7

[Sushil]

Attachment: Use GPU Composition when a frame needs intermediate surface.

Use GPU Composition when a frame needs intermediate surface. It is because HWC composes only leaf layers but not the containers so it is always safer to let GPU handle a frame which needs intermediate surface to make sure HwcComposer2D do not break the feature.

Comment 8

[Diego Wilson [:diego]]

Comment on attachment 8417509 [details] [diff] [review]
Use GPU Composition when a frame needs intermediate surface.

LGTM

Comment 9

[Sushil]

Attachment: Use GPU Composition when a frame needs intermediate surface. r=dwilson

Uploading HG friendly version of reviewed patch.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/da8a29e6fcd8

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/da8a29e6fcd8

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/e48277484f2a