Closed
Bug 999742
Opened 12 years ago
Closed 12 years ago
Split Blob<> into BlobParent/BlobChild
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
(Whiteboard: [qa-])
Attachments
(2 files, 1 obsolete file)
|
79.02 KB,
patch
|
Details | Diff | Splinter Review | |
|
76.19 KB,
patch
|
Details | Diff | Splinter Review |
The Blob template has outlived its usefulness, let's split it into two classes. Attached patch does not change any functionality.
Attachment #8410583 -
Flags: review?(jonas)
Comment on attachment 8410583 [details] [diff] [review]
Patch, v1
Review of attachment 8410583 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me based on skimming and the fact that you've said there are no behavioral changes here, just syntax changes.
Attachment #8410583 -
Flags: review?(jonas)
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
|
Assignee | |
Comment 4•12 years ago
|
||
Bug 982779 is 1.4+ and this patch is needed to avoid a painful (and maybe error-prone) rebase. Given that this patch is purely mechanical with no side effects I'd like to uplift this to 1.4 also.
blocking-b2g: --- → 1.4?
|
||
Comment 5•12 years ago
|
||
1.4+ because it's a mechanical change and makes uplifting bug 982779 easier.
blocking-b2g: 1.4? → 1.4+
|
||
Comment 6•12 years ago
|
||
This needs to be rebased around bug 910010 for b2g30 uplift :(
Flags: needinfo?(bent.mozilla)
Keywords: branch-patch-needed
|
|
||
Updated•12 years ago
|
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → fixed
status-firefox29:
--- → wontfix
status-firefox30:
--- → wontfix
status-firefox31:
--- → fixed
|
|
Assignee | |
Comment 7•12 years ago
|
||
Flags: needinfo?(bent.mozilla)
|
|
Assignee | |
Comment 8•12 years ago
|
||
Comment on attachment 8419053 [details] [diff] [review]
Patch for b2g30_v1_4
Oops, missing a file
Attachment #8419053 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•12 years ago
|
||
|
|
||
Comment 10•12 years ago
|
||
Keywords: branch-patch-needed
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•